From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id A84A93858C00 for ; Fri, 27 Jan 2023 17:38:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A84A93858C00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4P3Ptc2FBnz1r1Mh; Fri, 27 Jan 2023 18:38:15 +0100 (CET) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4P3Ptb5Zdkz1qqlR; Fri, 27 Jan 2023 18:38:15 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id 4VY2uInH0vnx; Fri, 27 Jan 2023 18:38:15 +0100 (CET) X-Auth-Info: LJ8+OWM8mSaJDgDpD6F/IjmXG8drtrJeohayvDEd/uJznvh35teI6wmjcObUuDoj Received: from igel.home (aftr-82-135-86-215.dynamic.mnet-online.de [82.135.86.215]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 27 Jan 2023 18:38:14 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id A661B2C159D; Fri, 27 Jan 2023 18:38:14 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Cc: "Andreas K . Huettel" , Paul Eggert , Florian Weimer , Adhemerval Zanella Subject: Re: [PATCH v5 1/5] linux: Use getdents64 on non-LFS readdir References: <20230127172834.391311-1-adhemerval.zanella@linaro.org> <20230127172834.391311-2-adhemerval.zanella@linaro.org> X-Yow: Yow! Am I JOGGING yet?? Date: Fri, 27 Jan 2023 18:38:14 +0100 In-Reply-To: <20230127172834.391311-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 27 Jan 2023 14:28:30 -0300") Message-ID: <87v8krdgjd.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Jan 27 2023, Adhemerval Zanella via Libc-alpha wrote: > + /* Non-lfs opendir skips entries that can not be represented (for > + instance if d_off is not an offset but rather an internal filesystem > + representation. For this case there is no point in continue the > + testcase. */ Missing close paren. Either "in continuing" or "to continue". -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."