From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 678DA3858C55 for ; Thu, 13 Oct 2022 12:11:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 678DA3858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665663088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ToLRYGTMud3qMs6vZm5zYe1mg7s7r3DV2cZlPXA0KD8=; b=QJIJc6CkSy3oBTduVBchfPvj5zbra0MpdDaZL1bQi5AbhbQDApEkSIaFjp1rOfdTeidhZH 382Ps6sbGT03ABGWvkHq3EVBr7Mp1Jre9/af4lZht2Xg+6IvlcXgWsACVTuuYSyEbEmlUv zh9wPymIWF+KTzXc+p/eimgu855LlKk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-lPm9pQjXOt-JxAPOGUQh-g-1; Thu, 13 Oct 2022 08:11:25 -0400 X-MC-Unique: lPm9pQjXOt-JxAPOGUQh-g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6767A29DD994; Thu, 13 Oct 2022 12:11:25 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BEDB72024CBE; Thu, 13 Oct 2022 12:11:24 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: Florian Weimer via Libc-alpha Subject: Re: [PATCH] elf: Introduce to _dl_call_fini References: <87zge0x8fr.fsf@oldenburg.str.redhat.com> Date: Thu, 13 Oct 2022 14:11:22 +0200 In-Reply-To: (Andreas Schwab's message of "Thu, 13 Oct 2022 14:03:38 +0200") Message-ID: <87v8onylcl.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Andreas Schwab: > On Okt 13 2022, Florian Weimer via Libc-alpha wrote: > >> This consolidates the destructor invocations from _dl_fini and >> dlclose. Remove the micro-optimization that avoids >> calling _dl_call_fini if they are no destructors (as dlclose is quite >> expensive anyway). > > This also changes whether to print the debug message. I've added, =E2=80=9CThe debug log message is now printed unconditionally.= =E2=80=9D The change is practically invisible because crtbegin*.o from GCC has a destructor. >> @@ -53,6 +53,7 @@ routines =3D \ >> # profiled libraries. >> dl-routines =3D \ >> dl-call-libc-early-init \ >> + dl-call_fini \ > > Convention is to use dashes in file names. I think we tend to use the underscore if it matches the symbol name verbatim (perhaps without the _dl_ prefix). Thanks, Florian