From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 63B34385AC11 for ; Thu, 25 Aug 2022 08:03:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 63B34385AC11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661414599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3JTc5cf4Bxuqd/xIhPq80maMtP8EJt7iHNm9mpSzkFs=; b=avsyD7bSxrfZBTIp5GwsjbsQ+Tg3KKkpTM/9e4/DYTQY8WQWTFKTonjU94WZ5dcmJJQsVt m/E5IfnafsRCH/L/mHXi3ETp96CL7v3xofSKaJzPvx2JOmwCbsBAChf8dD1zA9alBJzYAj bZg/rpdWd5OWxWRHTKG2iW2bZIsI0rw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-246-OP_8y_kjMdSK_HCnF49Oxw-1; Thu, 25 Aug 2022 04:03:17 -0400 X-MC-Unique: OP_8y_kjMdSK_HCnF49Oxw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AB501101E168; Thu, 25 Aug 2022 08:03:17 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 131254010D42; Thu, 25 Aug 2022 08:03:16 +0000 (UTC) From: Florian Weimer To: Radostin Stoyanov Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] linux: Fix sys/mount.h usage of FSOPEN_CLOEXEC References: <20220825064959.42153-1-rstoyanov@fedoraproject.org> Date: Thu, 25 Aug 2022 10:03:15 +0200 In-Reply-To: <20220825064959.42153-1-rstoyanov@fedoraproject.org> (Radostin Stoyanov's message of "Thu, 25 Aug 2022 08:49:59 +0200") Message-ID: <87v8qgbvi4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Radostin Stoyanov: > In commit 774058d72942249f71d74e7f2b639f77184160a6 was introduced > ifndef FSOPEN_CLOEXEC condition surrounding fsconfig_command. > However, the compilation would fail when there are multiple > `define FSOPEN_CLOEXEC`. This patch moves the #endif for > `#ifndef FSOPEN_CLOEXEC` after `#define FSOPEN_CLOEXEC`. > > Signed-off-by: Radostin Stoyanov Do you have an example of such a compilation failure? Redudant definitions with the same token sequence do not result in warnings. With the redundant definition, we can check if the kernel value and our value still match. Thanks, Florian