From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9468C3858D1E for ; Tue, 8 Feb 2022 20:34:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9468C3858D1E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-271-RbJcPHhUOyWqQEskGaJLVA-1; Tue, 08 Feb 2022 15:34:47 -0500 X-MC-Unique: RbJcPHhUOyWqQEskGaJLVA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1783B86A8A3; Tue, 8 Feb 2022 20:34:46 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DC7C610A6; Tue, 8 Feb 2022 20:34:45 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 5/5] Linux: Consolidate auxiliary vector parsing References: <151c5398adbbe538a275ea5ac77705b0abd0d748.1643886336.git.fweimer@redhat.com> <2b39ebaf-98ee-d0c2-39f6-6b0a87d0741a@linaro.org> Date: Tue, 08 Feb 2022 21:34:43 +0100 In-Reply-To: <2b39ebaf-98ee-d0c2-39f6-6b0a87d0741a@linaro.org> (Adhemerval Zanella's message of "Tue, 8 Feb 2022 17:19:42 -0300") Message-ID: <87v8xp3xng.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 20:34:53 -0000 * Adhemerval Zanella: >> diff --git a/sysdeps/unix/sysv/linux/dl-parse_auxv.h b/sysdeps/unix/sysv/linux/dl-parse_auxv.h >> new file mode 100644 >> index 0000000000..f450c6c5ce >> --- /dev/null >> +++ b/sysdeps/unix/sysv/linux/dl-parse_auxv.h >> +typedef ElfW(Addr) dl_parse_auxv_t[AT_MINSIGSTKSZ + 1]; >> + >> +/* Copy the auxiliary vector into AUX_VALUES and set up GLRO >> + variables. */ >> +static inline >> +void _dl_parse_auxv (ElfW(auxv_t) *av, dl_parse_auxv_t auxv_values) >> +{ >> + auxv_values[AT_ENTRY] = (ElfW(Addr)) ENTRY_POINT; > > Extra whitespace. Fxied. >> + auxv_values[AT_PAGESZ] = EXEC_PAGESIZE; >> + auxv_values[AT_FPUCW] = _FPU_DEFAULT; >> + >> + /* NB: Default to a constant CONSTANT_MINSIGSTKSZ. */ >> + _Static_assert (__builtin_constant_p (CONSTANT_MINSIGSTKSZ), >> + "CONSTANT_MINSIGSTKSZ is constant"); > > Shouldn't it warn that CONSTANT_MINSIGSTKSZ is not a constant? Sorry, would please rephrase? Should I change this to ""CONSTANT_MINSIGSTKSZ is not constant"? >> + auxv_values[AT_MINSIGSTKSZ] = CONSTANT_MINSIGSTKSZ; >> + >> + for (; av->a_type != AT_NULL; av++) >> + if (av->a_type <= AT_MINSIGSTKSZ) >> + auxv_values[av->a_type] = av->a_un.a_val; >> + >> + GLRO(dl_pagesize) = auxv_values[AT_PAGESZ]; >> + __libc_enable_secure = auxv_values[AT_SECURE]; >> + GLRO(dl_platform) = (void *) auxv_values[AT_PLATFORM]; >> + GLRO(dl_hwcap) = auxv_values[AT_HWCAP]; >> + GLRO(dl_hwcap2) = auxv_values[AT_HWCAP2]; >> + GLRO(dl_clktck) = auxv_values[AT_CLKTCK]; >> + GLRO(dl_fpu_control) = auxv_values[AT_FPUCW]; >> + _dl_random = (void *) auxv_values[AT_RANDOM]; >> + GLRO(dl_minsigstacksize) = auxv_values[AT_MINSIGSTKSZ]; >> + GLRO(dl_sysinfo_dso) = (void *) auxv_values[AT_SYSINFO_EHDR]; >> +#ifdef NEED_DL_SYSINFO > > I think you can now assume NEED_DL_SYSINFO is always defined. NEED_DL_SYSINFO is only defined by i386 and ia64, only NEED_DL_SYSINFO_DSO is always defined on Linux. Thanks, Florian