From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id A25F93858D28 for ; Mon, 7 Feb 2022 15:46:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A25F93858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Jsr8X4hgGz1tMTd; Mon, 7 Feb 2022 16:46:04 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Jsr8X0wBTz1qqkC; Mon, 7 Feb 2022 16:46:04 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id GpeMbaNwDqgH; Mon, 7 Feb 2022 16:46:03 +0100 (CET) X-Auth-Info: Snra0qOwMMk/NSDClAUgsL8kh4MIKtvmd5lFI+glz+TDRgxRHwxKIpKuVujpkBLn Received: from igel.home (ppp-46-244-191-16.dynamic.mnet-online.de [46.244.191.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 7 Feb 2022 16:46:03 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id CAF202C3768; Mon, 7 Feb 2022 16:46:02 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Cc: John David Anglin , Adhemerval Zanella Subject: Re: [PATCH v3] hppa: Fix bind-now audit (BZ #28857) References: <20220207141511.668554-1-adhemerval.zanella@linaro.org> X-Yow: How do I get HOME? Date: Mon, 07 Feb 2022 16:46:02 +0100 In-Reply-To: <20220207141511.668554-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 7 Feb 2022 11:15:11 -0300") Message-ID: <87v8xqvfwl.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 15:46:07 -0000 On Feb 07 2022, Adhemerval Zanella via Libc-alpha wrote: > +/* Clear the plabel bit to get the actual address of the descriptor. */ > +#define DL_FIXUP_ADDR_VALUE(addr) \ > + (*(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (addr) & ~2)) Why not uintptr_t? > +#define DL_FIXUP_BINDNOW_RELOC(value, new_value, st_value) \ > + *(value) = *(DL_FIXUP_VALUE_TYPE *) ((unsigned int) (new_value) & ~2); Likewise. Why is there a semicolon? -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."