public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>,
	 Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH 1/2] localedef: Fix handling of empty mon_decimal_point
Date: Mon, 31 Jan 2022 17:20:57 +0100	[thread overview]
Message-ID: <87v8xz7u6u.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <87ee4n6g56.fsf@igel.home> (Andreas Schwab's message of "Mon, 31 Jan 2022 17:09:41 +0100")

* Andreas Schwab:

> On Jan 31 2022, Florian Weimer via Libc-alpha wrote:
>
>> There's an existing comment
>>
>>   /* The decimal point must not be empty.  This is not said explicitly
>>      in POSIX but ANSI C (ISO/IEC 9899) says in 4.4.2.1 it has to be
>>      != "".  */
>>
>> that says that empty strings/null characters are invalid.
>
> This is only about decimal_point, mon_decimal_point can be empty.

Hmm, I'll take your word for it.

So the comment should definitely go, and the Carlos' change is the right
way to do it?

Thanks,
Florian


  reply	other threads:[~2022-01-31 16:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-31  5:34 [PATCH 0/2] Make C/POSIX and C.UTF-8 consistent Carlos O'Donell
2022-01-31  5:34 ` [PATCH 1/2] localedef: Fix handling of empty mon_decimal_point Carlos O'Donell
2022-01-31 15:26   ` Florian Weimer
2022-01-31 16:09     ` Andreas Schwab
2022-01-31 16:20       ` Florian Weimer [this message]
2022-01-31 16:30         ` Andreas Schwab
2022-01-31 16:37           ` Florian Weimer
2022-02-01 11:47   ` Florian Weimer
2022-02-01 16:00     ` Carlos O'Donell
2022-02-01 16:14       ` Carlos O'Donell
2022-01-31  5:34 ` [PATCH 2/2] localedata: Adjust C.UTF-8 to align with C/POSIX Carlos O'Donell
2022-01-31  8:47   ` Andreas Schwab
2022-01-31 16:07     ` Carlos O'Donell
2022-02-01 12:05   ` Florian Weimer
2022-02-01 16:13     ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8xz7u6u.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).