From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 41D7A3858410 for ; Mon, 20 Dec 2021 21:34:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41D7A3858410 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26--pXlMnL8MBOAtTjar76bew-1; Mon, 20 Dec 2021 16:34:50 -0500 X-MC-Unique: -pXlMnL8MBOAtTjar76bew-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6A741023F4D; Mon, 20 Dec 2021 21:34:49 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.104]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72CCC73142; Mon, 20 Dec 2021 21:34:48 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v6 19/20] elf: Fix runtime linker auditing on aarch64 (BZ #26643) References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-20-adhemerval.zanella@linaro.org> Date: Mon, 20 Dec 2021 22:34:46 +0100 In-Reply-To: <20211115183734.531155-20-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 15 Nov 2021 15:37:33 -0300") Message-ID: <87v8zjc64p.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Dec 2021 21:34:58 -0000 * Adhemerval Zanella: > diff --git a/sysdeps/aarch64/bits/link.h b/sysdeps/aarch64/bits/link.h > index 774bbe5f45..2af90ca6be 100644 > --- a/sysdeps/aarch64/bits/link.h > +++ b/sysdeps/aarch64/bits/link.h > @@ -20,23 +20,29 @@ > # error "Never include directly; use instead." > #endif > =20 > +typedef union > +{ > + float s; > + double d; > + long double q; > +} La_aarch64_vector; > + > /* Registers for entry into PLT on AArch64. */ > typedef struct La_aarch64_regs > { > - uint64_t lr_xreg[8]; > - uint64_t lr_dreg[8]; > - uint64_t lr_sp; > - uint64_t lr_lr; > + uint64_t lr_xreg[9]; > + La_aarch64_vector lr_vreg[8]; > + uint64_t lr_sp; > + uint64_t lr_lr; > } La_aarch64_regs; Ultimately this is up to the aarch64 maintainers to review, but I wonder if it would make sense to extend support to non-standard calling conventions by preserving more GPRs and vector registers. (There is also talk of a C++-specific calling convention that uses the carry flag as part of the function return =E2=80=A6) Thanks, Florian