From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 40F9F3857C45 for ; Fri, 10 Dec 2021 12:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 40F9F3857C45 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-172-0jhaSbrDPXqp8UI1Re_f8w-1; Fri, 10 Dec 2021 07:59:04 -0500 X-MC-Unique: 0jhaSbrDPXqp8UI1Re_f8w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 379F61927800; Fri, 10 Dec 2021 12:59:03 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 40EC260BE5; Fri, 10 Dec 2021 12:59:02 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v2 2/2] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ #28350) References: <20210929140619.279302-1-adhemerval.zanella@linaro.org> <20210929140619.279302-2-adhemerval.zanella@linaro.org> <878rwsbrri.fsf@oldenburg.str.redhat.com> <32567bed-9014-3db5-371a-56d4a8420966@linaro.org> <87zgp88vpm.fsf@oldenburg.str.redhat.com> Date: Fri, 10 Dec 2021 13:59:00 +0100 In-Reply-To: <87zgp88vpm.fsf@oldenburg.str.redhat.com> (Florian Weimer's message of "Fri, 10 Dec 2021 13:56:21 +0100") Message-ID: <87v8zw8vl7.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 12:59:08 -0000 * Florian Weimer: > * Adhemerval Zanella: > >> Indeed I think it should be safe to drop the check, we already check >> if before with CMSG_SPACE and return MSG_CTRUNC if this is no extra >> space (which will make CMSG_NXTHDR return NULL). >> >> Are you ok with this change? > > Let me read it again =E2=80=A6 I don't see how we patch anything if CMSG_NEXT (msg, last) is null. Thanks, Florian