public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org,  carlos@redhat.com,  dj@redhat.com
Subject: Re: [PATCH v9 00/10] malloc hooks removal
Date: Mon, 19 Jul 2021 13:07:27 +0200	[thread overview]
Message-ID: <87v956y32o.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210719024134.155398-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Mon, 19 Jul 2021 08:11:24 +0530")

This series break old Emacs binaries (e.g. emacs-24.3-23.el7.x86_64):

$ bash testrun.sh /usr/bin/emacs

Fatal error 11: Segmentation fault
Backtrace:
/usr/bin/emacs[0x4f8653]
/usr/bin/emacs[0x4ddc81]
/usr/bin/emacs[0x4f70ee]
/usr/bin/emacs[0x4f7273]
./libc.so.6(+0x3cd80)[0x7f88c1a14d80]
./libc.so.6(+0x90c21)[0x7f88c1a68c21]
./libc.so.6(+0x94011)[0x7f88c1a6c011]
./libc.so.6(realloc+0x291)[0x7f88c1a6cea1]
/usr/bin/emacs[0x536ef2]
/usr/bin/emacs(re_compile_pattern+0x9cc)[0x53074c]
/usr/bin/emacs[0x5242c7]
/usr/bin/emacs[0x524d69]
/usr/bin/emacs[0x526259]
/usr/bin/emacs[0x5264bc]
/usr/bin/emacs[0x551b87]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x55171f]
/usr/bin/emacs[0x551a2b]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x55171f]
/usr/bin/emacs[0x551a2b]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x55171f]
/usr/bin/emacs[0x551a2b]
/usr/bin/emacs[0x551dcf]
/usr/bin/emacs[0x51243c]
/usr/bin/emacs[0x551b6e]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x55171f]
/usr/bin/emacs[0x551a2b]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x55171f]
/usr/bin/emacs[0x551a2b]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x551a2b]
/usr/bin/emacs[0x586c0b]
/usr/bin/emacs[0x550b3d]
/usr/bin/emacs[0x550f02]
/usr/bin/emacs[0x5544ad]
/usr/bin/emacs[0x55002a]
/usr/bin/emacs[0x4de186]
...
Segmentation fault

It is customary to call malloc_set_state from __malloc_initialize_hook.
If we no longer call __malloc_initialize_hook, we probably should change
malloc_set_state to provide a better error message (via __libc_fatal).

Thanks,
Florian


  parent reply	other threads:[~2021-07-19 11:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  2:41 Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 01/10] Make mcheck tests conditional on GLIBC_2.23 or earlier Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 02/10] Remove __after_morecore_hook Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 03/10] Remove __morecore and __default_morecore Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 04/10] Move malloc hooks into a compat DSO Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 05/10] mcheck: Wean away from malloc hooks [BZ #23489] Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 06/10] Simplify __malloc_initialized Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 07/10] mtrace: Wean away from malloc hooks Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 08/10] glibc.malloc.check: " Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 09/10] Remove malloc hooks [BZ #23328] Siddhesh Poyarekar
2021-07-19  2:41 ` [PATCH v9 10/10] mcheck Fix malloc_usable_size [BZ #22057] Siddhesh Poyarekar
2021-07-19 11:07 ` Florian Weimer [this message]
2021-07-19 11:09   ` [PATCH v9 00/10] malloc hooks removal Siddhesh Poyarekar
2021-07-19 11:11     ` Florian Weimer
2021-07-19 11:17       ` Siddhesh Poyarekar
2021-07-19 11:20         ` Florian Weimer
2021-07-19 11:40           ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v956y32o.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=dj@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).