From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9DB58385F02C for ; Mon, 19 Jul 2021 11:07:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9DB58385F02C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-aItcGVGwPiCpvjs4Chb7Og-1; Mon, 19 Jul 2021 07:07:36 -0400 X-MC-Unique: aItcGVGwPiCpvjs4Chb7Og-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEA811932482; Mon, 19 Jul 2021 11:07:35 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-73.phx2.redhat.com [10.3.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B56769FAD; Mon, 19 Jul 2021 11:07:30 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org, carlos@redhat.com, dj@redhat.com Subject: Re: [PATCH v9 00/10] malloc hooks removal References: <20210719024134.155398-1-siddhesh@sourceware.org> Date: Mon, 19 Jul 2021 13:07:27 +0200 In-Reply-To: <20210719024134.155398-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Mon, 19 Jul 2021 08:11:24 +0530") Message-ID: <87v956y32o.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jul 2021 11:07:40 -0000 This series break old Emacs binaries (e.g. emacs-24.3-23.el7.x86_64): $ bash testrun.sh /usr/bin/emacs Fatal error 11: Segmentation fault Backtrace: /usr/bin/emacs[0x4f8653] /usr/bin/emacs[0x4ddc81] /usr/bin/emacs[0x4f70ee] /usr/bin/emacs[0x4f7273] ./libc.so.6(+0x3cd80)[0x7f88c1a14d80] ./libc.so.6(+0x90c21)[0x7f88c1a68c21] ./libc.so.6(+0x94011)[0x7f88c1a6c011] ./libc.so.6(realloc+0x291)[0x7f88c1a6cea1] /usr/bin/emacs[0x536ef2] /usr/bin/emacs(re_compile_pattern+0x9cc)[0x53074c] /usr/bin/emacs[0x5242c7] /usr/bin/emacs[0x524d69] /usr/bin/emacs[0x526259] /usr/bin/emacs[0x5264bc] /usr/bin/emacs[0x551b87] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x55171f] /usr/bin/emacs[0x551a2b] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x55171f] /usr/bin/emacs[0x551a2b] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x55171f] /usr/bin/emacs[0x551a2b] /usr/bin/emacs[0x551dcf] /usr/bin/emacs[0x51243c] /usr/bin/emacs[0x551b6e] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x55171f] /usr/bin/emacs[0x551a2b] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x55171f] /usr/bin/emacs[0x551a2b] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x551a2b] /usr/bin/emacs[0x586c0b] /usr/bin/emacs[0x550b3d] /usr/bin/emacs[0x550f02] /usr/bin/emacs[0x5544ad] /usr/bin/emacs[0x55002a] /usr/bin/emacs[0x4de186] ... Segmentation fault It is customary to call malloc_set_state from __malloc_initialize_hook. If we no longer call __malloc_initialize_hook, we probably should change malloc_set_state to provide a better error message (via __libc_fatal). Thanks, Florian