public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf/tests: Make thrlock and noload depend on libm
Date: Thu, 08 Jul 2021 08:15:45 +0200	[thread overview]
Message-ID: <87v95lxre6.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <bc1b6bbd-dcb5-f326-d7f3-5780fbe2a709@sourceware.org> (Siddhesh Poyarekar's message of "Thu, 8 Jul 2021 11:42:53 +0530")

* Siddhesh Poyarekar:

> On 7/8/21 11:39 AM, Florian Weimer via Libc-alpha wrote:
>> * Siddhesh Poyarekar:
>> 
>>> Oh, and running only tests (assuming that all built objects are up to
>>> date) won't do this.  It'll only happen if some object needs to be
>>> updated when the test is run because an undercaffeinated developer ran
>>> make check instead of make && make check :)
>> If you do that, you'll likely end up with corrupt objects anyway.
>> I think some assert in allocatestack.c is particularly common
>> (or at least was when we still had a separate libpthread).  It
>> definitely invalidates testing.
>> We really need to fix that, but the dependency won't help with that.
>> (But as I said, adding the dependency is correct, just the commit
>> message is misleading.)
>
> OK, I'll update the commit message to say:
>
> Both tests try to dlopen libm.so at runtime, so make them depend on it
> so that they're executed if libm.so has been updated.

Thanks. 8-)

Florian


      reply	other threads:[~2021-07-08  6:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 16:58 Siddhesh Poyarekar
2021-07-07 17:06 ` Florian Weimer
2021-07-07 17:22   ` Siddhesh Poyarekar
2021-07-08  5:46     ` Florian Weimer
2021-07-08  6:01       ` Siddhesh Poyarekar
2021-07-08  6:09         ` Florian Weimer
2021-07-08  6:12           ` Siddhesh Poyarekar
2021-07-08  6:15             ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v95lxre6.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).