From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <whitebox@nefkom.net>
Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])
 by sourceware.org (Postfix) with ESMTPS id 3E7C63943402
 for <libc-alpha@sourceware.org>; Mon, 28 Jun 2021 07:26:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E7C63943402
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=linux-m68k.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net
Received: from frontend01.mail.m-online.net (unknown [192.168.8.182])
 by mail-out.m-online.net (Postfix) with ESMTP id 4GCzg56j4bz1s46n;
 Mon, 28 Jun 2021 09:26:09 +0200 (CEST)
Received: from localhost (dynscan1.mnet-online.de [192.168.6.70])
 by mail.m-online.net (Postfix) with ESMTP id 4GCzg56Bnpz1qql7;
 Mon, 28 Jun 2021 09:26:09 +0200 (CEST)
X-Virus-Scanned: amavisd-new at mnet-online.de
Received: from mail.mnet-online.de ([192.168.8.182])
 by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,
 port 10024)
 with ESMTP id Of9GhCNvgGEO; Mon, 28 Jun 2021 09:26:09 +0200 (CEST)
X-Auth-Info: VtR65zwHkHKOlFzmKKgC56S5SqBKQQ1wc5owYFC5vJ1BfdXSsVlhNTe3+yIGh0l8
Received: from igel.home (ppp-46-244-166-56.dynamic.mnet-online.de
 [46.244.166.56])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail.mnet-online.de (Postfix) with ESMTPSA;
 Mon, 28 Jun 2021 09:26:09 +0200 (CEST)
Received: by igel.home (Postfix, from userid 1000)
 id BA6112C1F89; Mon, 28 Jun 2021 09:26:08 +0200 (CEST)
From: Andreas Schwab <schwab@linux-m68k.org>
To: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] elf: Assert range of ns argument in _dl_debug_initialize
References: <87y2b04us6.fsf@oldenburg.str.redhat.com>
X-Yow: It's OKAY --- I'm an INTELLECTUAL, too.
Date: Mon, 28 Jun 2021 09:26:08 +0200
In-Reply-To: <87y2b04us6.fsf@oldenburg.str.redhat.com> (Florian Weimer via
 Libc-alpha's message of "Wed, 23 Jun 2021 14:42:17 +0200")
Message-ID: <87v95y8n73.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2021 07:26:12 -0000

On Jun 23 2021, Florian Weimer via Libc-alpha wrote:

> @@ -49,7 +51,11 @@ _dl_debug_initialize (ElfW(Addr) ldbase, Lmid_t ns)
>    if (ns == LM_ID_BASE)
>      r = &_r_debug;
>    else
> -    r = &GL(dl_ns)[ns]._ns_debug;
> +    {
> +      assert (ns >= 0);
> +      assert (ns < array_length (GL (dl_ns)));

The asserts can be combined.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."