From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3196B385703C for ; Fri, 23 Apr 2021 16:00:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3196B385703C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-125-2zo4k31yOkO4l8FLG5oRGw-1; Fri, 23 Apr 2021 12:00:51 -0400 X-MC-Unique: 2zo4k31yOkO4l8FLG5oRGw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AFC3E51F9; Fri, 23 Apr 2021 16:00:50 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-20.ams2.redhat.com [10.36.113.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ABB6E5D6D1; Fri, 23 Apr 2021 16:00:49 +0000 (UTC) From: Florian Weimer To: Martin Sebor Cc: Martin Sebor via Libc-alpha , Joseph Myers Subject: Re: [PATCH] more out of bounds checking improvements References: <176ba75f-4299-073f-8319-66dbf9fe3f42@gmail.com> <87k0ot9trs.fsf@oldenburg.str.redhat.com> Date: Fri, 23 Apr 2021 18:01:09 +0200 In-Reply-To: (Martin Sebor's message of "Fri, 23 Apr 2021 09:06:44 -0600") Message-ID: <87v98d6ldm.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 16:00:55 -0000 * Martin Sebor: > On 4/23/21 4:31 AM, Florian Weimer wrote: >> * Martin Sebor via Libc-alpha: >> >>> diff --git a/sysdeps/gnu/net/if.h b/sysdeps/gnu/net/if.h >>> index e587a5ce59..30f3e281e5 100644 >>> --- a/sysdeps/gnu/net/if.h >>> +++ b/sysdeps/gnu/net/if.h >>> @@ -191,7 +191,9 @@ __BEGIN_DECLS >>> /* Convert an interface name to an index, and vice versa. */ >>> extern unsigned int if_nametoindex (const char *__ifname) __THROW; >>> -extern char *if_indextoname (unsigned int __ifindex, char *__ifname) __THROW; >>> +extern char *if_indextoname (unsigned int __ifindex, >>> + char __ifname[IF_NAMESIZE]) __THROW >>> + __attr_access ((__write_only__, 2)); >>> /* Return a list of all interfaces and their indices. */ >>> extern struct if_nameindex *if_nameindex (void) __THROW; >> Is the change from a pointer to an array allowed by POSIX? > > There's no way for a conforming program to tell how a function pointer > parameter is declared so I believe it is. Hmm, I think you might be right. It's like parameter names in this regard. Thanks, Florian