From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id C2418385801A for ; Sat, 27 Mar 2021 16:57:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C2418385801A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-G0J3tOdDMQioe7_b2_PupA-1; Sat, 27 Mar 2021 12:57:22 -0400 X-MC-Unique: G0J3tOdDMQioe7_b2_PupA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0B7C7501EC; Sat, 27 Mar 2021 16:57:22 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30A71614ED; Sat, 27 Mar 2021 16:57:21 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 19/37] dlfcn: Failures after dlmopen should not terminate process [BZ #24772] References: Date: Sat, 27 Mar 2021 17:57:47 +0100 In-Reply-To: (Adhemerval Zanella's message of "Fri, 19 Mar 2021 16:56:40 -0300") Message-ID: <87v99c5yb8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2021 16:57:29 -0000 * Adhemerval Zanella: >> diff --git a/elf/dl-error-skeleton.c b/elf/dl-error-skeleton.c >> index 2fd62777cf..b699936c6e 100644 >> --- a/elf/dl-error-skeleton.c >> +++ b/elf/dl-error-skeleton.c >> @@ -248,4 +248,16 @@ _dl_receive_error (receiver_fct fct, void (*operate) (void *), void *args) >> catch_hook = old_catch; >> receiver = old_receiver; >> } >> + >> +/* Forwarder used for initializing GLRO (_dl_catch_error). */ >> +int >> +_rtld_catch_error (const char **objname, const char **errstring, >> + bool *mallocedp, void (*operate) (void *), >> + void *args) >> +{ >> + /* The reference to _dl_catch_error will eventually be relocated to >> + point to the implementation in libc.so. */ >> + return _dl_catch_error (objname, errstring, mallocedp, operate, args); >> +} >> + >> #endif /* DL_ERROR_BOOTSTRAP */ > > Ok, but why change the usual prepend string to 'rtld'? _dl_catch_error is already taken. Thanks, Florian