build failure on gcc10

build failure on gcc10

[Paul Zimmermann]

       Hi,

I get a build failure on gcc10 (from the GCC compiler farm) with commit
fcfa4bb:

gcc ../sysdeps/x86/cacheinfo.c -c -std=gnu11 -fgnu89-inline  -g -O2 -Wall -Wwrite-strings -Wundef -Werror -fmerge-all-constants -frounding-math -fno-stack-protector -Wstrict-prototypes -Wold-style-definition -fmath-errno   -fPIC   -ftls-model=initial-exec      -I../include -I/home/zimmerma/glibc/build/string  -I/home/zimmerma/glibc/build  -I../sysdeps/unix/sysv/linux/x86_64/64  -I../sysdeps/unix/sysv/linux/x86_64  -I../sysdeps/unix/sysv/linux/x86/include -I../sysdeps/unix/sysv/linux/x86  -I../sysdeps/x86/nptl  -I../sysdeps/unix/sysv/linux/wordsize-64  -I../sysdeps/x86_64/nptl  -I../sysdeps/unix/sysv/linux/include -I../sysdeps/unix/sysv/linux  -I../sysdeps/nptl  -I../sysdeps/pthread  -I../sysdeps/gnu  -I../sysdeps/unix/inet  -I../sysdeps/unix/sysv  -I../sysdeps/unix/x86_64  -I../sysdeps/unix  -I../sysdeps/posix  -I../sysdeps/x86_64/64  -I../sysdeps/x86_64/fpu/multiarch  -I../sysdeps/x86_64/fpu  -I../sysdeps/x86/fpu  -I../sysdeps/x86_64/multiarch  -I../sysdeps/x86_64  -I../sysdeps/x86/include -I../sysdeps/x86  -I../sysdeps/ieee754/float128  -I../sysdeps/ieee754/ldbl-96/include -I../sysdeps/ieee754/ldbl-96  -I../sysdeps/ieee754/dbl-64  -I../sysdeps/ieee754/flt-32  -I../sysdeps/wordsize-64  -I../sysdeps/ieee754  -I../sysdeps/generic  -I.. -I../libio -I.   -D_LIBC_REENTRANT -include /home/zimmerma/glibc/build/libc-modules.h -DMODULE_NAME=libc -include ../include/libc-symbols.h  -DPIC -DSHARED     -DTOP_NAMESPACE=glibc -o /home/zimmerma/glibc/build/string/cacheinfo.os -MD -MP -MF /home/zimmerma/glibc/build/string/cacheinfo.os.dt -MT /home/zimmerma/glibc/build/string/cacheinfo.os
../sysdeps/x86/cacheinfo.c:81:5: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
   = __x86_cacheinfo;
     ^~~~~~~~~~~~~~~

Does that ring a bell?

Paul

Re: build failure on gcc10

[Andreas Schwab]

On Jan 25 2021, Paul Zimmermann wrote:

> ../sysdeps/x86/cacheinfo.c:81:5: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
>    = __x86_cacheinfo;
>      ^~~~~~~~~~~~~~~

Does that help?

diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
index 350cba5fda..7b8df45e3b 100644
--- a/sysdeps/x86/cacheinfo.c
+++ b/sysdeps/x86/cacheinfo.c
@@ -77,7 +77,7 @@ __cache_sysconf (int name)
 # include <ifunc-init.h>
 
 extern void __x86_cacheinfo (void) attribute_hidden;
-const void (*__x86_cacheinfo_p) (void) attribute_hidden
+void (*const __x86_cacheinfo_p) (void) attribute_hidden
   = __x86_cacheinfo;
 
 __ifunc (__x86_cacheinfo, __x86_cacheinfo, NULL, void, init_cacheinfo);
-- 
2.30.0


Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: build failure on gcc10

[Paul Zimmermann]

       Dear Andreas,

> Does that help?
> 
> diff --git a/sysdeps/x86/cacheinfo.c b/sysdeps/x86/cacheinfo.c
> index 350cba5fda..7b8df45e3b 100644
> --- a/sysdeps/x86/cacheinfo.c
> +++ b/sysdeps/x86/cacheinfo.c
> @@ -77,7 +77,7 @@ __cache_sysconf (int name)
>  # include <ifunc-init.h>
>  
>  extern void __x86_cacheinfo (void) attribute_hidden;
> -const void (*__x86_cacheinfo_p) (void) attribute_hidden
> +void (*const __x86_cacheinfo_p) (void) attribute_hidden
>    = __x86_cacheinfo;
>  
>  __ifunc (__x86_cacheinfo, __x86_cacheinfo, NULL, void, init_cacheinfo);
> -- 
> 2.30.0

yes it does. But then I get the same issue in sysdeps/x86/dl-get-cpu-features.c
(line 32). Applying the same patch enables one to build glibc.

Thanks,
Paul

Re: build failure on gcc10

[Andreas Schwab]

On Jan 25 2021, Paul Zimmermann wrote:

> yes it does. But then I get the same issue in sysdeps/x86/dl-get-cpu-features.c
> (line 32). Applying the same patch enables one to build glibc.

Thanks, pushed.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."