public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	GNU C Library <libc-alpha@sourceware.org>,
	Andreas Schwab <schwab@suse.de>,
	Stepan Golosunov <stepan@golosunov.pp.ru>,
	Alistair Francis <alistair.francis@wdc.com>,
	Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH] [RFC] y2038: nptl: Convert pthread_cond_{clock|timed}wait to support 64 bit time
Date: Wed, 26 Aug 2020 20:06:00 +0200	[thread overview]
Message-ID: <87v9h51dvb.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200826195906.50fb3854@jawa> (Lukasz Majewski's message of "Wed, 26 Aug 2020 19:59:06 +0200")

* Lukasz Majewski:

>> Some comments below.  As a general comment, I think you are using 8
>> whitespace instead of tab.
>
> Yes, correct. I've already enabled the "gnu" coding style
> (c-set-style) in emacs. It automatically replaces some spaces with tabs.
>
> However, with some earlier patches - such approach was not accepted and
> using 2 spaces for indentation like:
>
> if (foo)
>   {
>     if (baz)
>       flag = 1;
>
>   }

For new files, I prefer using spaces instead of tabs because the diffs
show the correct indentation.  With tabs, they sometimes do not because
the leading  /+/- does not shift a following tab one column right
(like it would do for eight spaces).

Thanks,
Florian


  reply	other threads:[~2020-08-26 18:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-24 16:40 Lukasz Majewski
2020-08-24 16:59 ` Lukasz Majewski
2020-08-24 17:15   ` Florian Weimer
2020-08-24 17:50     ` Lukasz Majewski
2020-08-25  8:08 ` Andreas Schwab
2020-08-25 10:03   ` Lukasz Majewski
2020-08-25 10:34     ` Andreas Schwab
2020-08-25 14:29       ` Adhemerval Zanella
2020-08-25 14:30       ` Lukasz Majewski
2020-08-25 14:47         ` Andreas Schwab
2020-08-25 14:53           ` Adhemerval Zanella
2020-08-25 15:26             ` Andreas Schwab
2020-08-25 15:31               ` Adhemerval Zanella
2020-08-25 15:36                 ` Adhemerval Zanella
2020-08-25 14:43 ` Adhemerval Zanella
2020-08-26 17:59   ` Lukasz Majewski
2020-08-26 18:06     ` Florian Weimer [this message]
2020-08-26 19:38     ` Adhemerval Zanella
2020-08-27  6:20       ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9h51dvb.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    --cc=schwab@suse.de \
    --cc=stepan@golosunov.pp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).