From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 06/13] powerpc64le: add -mno-gnu-attribute to *f128 objects and difftime
Date: Tue, 24 Mar 2020 17:42:49 -0300 [thread overview]
Message-ID: <87v9mtscvq.fsf@linux.ibm.com> (raw)
In-Reply-To: <20200306203721.15886-7-murphyp@linux.vnet.ibm.com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> diff --git a/sysdeps/powerpc/powerpc64/le/Makefile b/sysdeps/powerpc/powerpc64/le/Makefile
> index ee2b78bb5f..f23e2782f0 100644
> --- a/sysdeps/powerpc/powerpc64/le/Makefile
> +++ b/sysdeps/powerpc/powerpc64/le/Makefile
> @@ -161,6 +164,10 @@ $(foreach test, \
> gnulib-tests += $(f128-loader-link)
> endif
>
> +# Disable linker noise on files using ieee128 long double internally
> +ifeq ($(subdir),time)
> +CFLAGS-difftime.c = $(no-gnu-attribute-CFLAGS)
Shouldn't it use += instead?
LGTM with that change.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
--
Tulio Magno
next prev parent reply other threads:[~2020-03-24 20:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 20:37 [PATCH 00/13] Enable IEEE binary128 long double on powerpc64le Paul E. Murphy
2020-03-06 20:37 ` [PATCH 05/13] powerpc64le: link tests against ld.so Paul E. Murphy
[not found] ` <alpine.DEB.2.21.2003070026090.26274@digraph.polyomino.org.uk>
2020-03-09 22:38 ` Paul E Murphy
2020-03-09 23:19 ` Joseph Myers
2020-03-10 21:44 ` Paul E Murphy
2020-03-10 23:06 ` Joseph Myers
2020-03-06 20:37 ` [PATCH 04/13] powerpc64le: Ensure correct ldouble compiler flags are used Paul E. Murphy
2020-03-24 20:32 ` Tulio Magno Quites Machado Filho
2020-03-25 21:21 ` Paul E Murphy
2020-03-06 20:37 ` [PATCH 10/13] powerpc64le: raise GCC requirement to 7.3 for long double transition Paul E. Murphy
2020-03-06 20:37 ` [PATCH 11/13] powerpc64le: bump binutils version requirement to >= 2.26 Paul E. Murphy
2020-03-06 20:37 ` [PATCH 03/13] RFC: ldbl-128ibm-compat: workaround C++ redirect limitations Paul E. Murphy
2020-03-24 20:30 ` Tulio Magno Quites Machado Filho
2020-03-06 20:37 ` [PATCH 06/13] powerpc64le: add -mno-gnu-attribute to *f128 objects and difftime Paul E. Murphy
2020-03-24 20:42 ` Tulio Magno Quites Machado Filho [this message]
2020-03-25 21:21 ` Paul E Murphy
2020-03-06 20:37 ` [PATCH 02/13] Fix tests which expose ldbl -> _Float128 redirects Paul E. Murphy
2020-03-13 21:37 ` Tulio Magno Quites Machado Filho
2020-03-25 21:20 ` Paul E Murphy
2020-03-06 20:37 ` [PATCH 12/13] powerpc64le: enforce non-specific long double in .gnu.attributes section Paul E. Murphy
2020-03-06 20:37 ` [PATCH 09/13] powerpc64le: workaround ieee long double / _Float128 stdc++ bug Paul E. Murphy
2020-03-06 20:37 ` [PATCH 01/13] ldbl-128ibm-compat: PLT redirects for using ldbl redirects internally Paul E. Murphy
2020-03-16 17:29 ` Paul E Murphy
2020-03-24 18:28 ` Tulio Magno Quites Machado Filho
2020-03-25 21:20 ` Paul E Murphy
2020-03-06 20:37 ` [PATCH 08/13] powerpc64le: Enforce -mabi=ibmlongdouble when -mfloat128 used Paul E. Murphy
[not found] ` <alpine.DEB.2.21.2003070033530.26274@digraph.polyomino.org.uk>
2020-03-09 14:30 ` Paul E Murphy
2020-03-06 20:52 ` [PATCH 13/13] powerpc64le: Enable support for IEEE long double Paul E. Murphy
[not found] ` <20200306203721.15886-8-murphyp@linux.vnet.ibm.com>
2020-03-24 20:59 ` [PATCH 07/13] powerpc64: apply -mabi=ibmlongdouble to special files Tulio Magno Quites Machado Filho
2020-03-25 21:22 ` Paul E Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9mtscvq.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=libc-alpha@sourceware.org \
--cc=murphyp@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).