public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 libc-alpha@sourceware.org
Subject: Re: [PATCH] [GLIBC RFC] clone3: add CLONE3_RESET_SIGHAND
Date: Wed, 09 Oct 2019 12:01:00 -0000	[thread overview]
Message-ID: <87v9syyvpd.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20191009115846.xs4uou6c2x67pqz7@wittgenstein> (Christian Brauner's message of "Wed, 9 Oct 2019 13:58:47 +0200")

* Christian Brauner:

>> With this construct, the application programmer needs to remember which
>> flags are old and new (predate and postdate known_flags).  It's too easy
>> to make mistakes there.
>> 
>> What about this?
>> 
>>   pid_t pid = clone3 (&args, sizeof (args));
>>   if (pid < 0)
>>     return -1;
>> 
>>   if (args.known_flags == 0)
>>     args.known_flags = CLONE3_INITIALLY_SUPPORTED_FLAGS;
>> 
>>   if (args.known_flags & NEW_FLAG_I_CARE_ABOUT)
>>     /* Kernel does support the known_flags extension and does
>>        support the feature I care about.  */
>> 
>> We could hide this in the clone3 wrapper for glibc if we start out with
>> a struct clone_args that has this member.
>
> So the kernel semantics I suggested but when the kernel does not support
> it have and doesn't set it have glibc set this?

Exactly.

> Yeah, that sounds like a good idea to me!

Good.  Please get this into the kernel. 8-)

Thanks,
Florian

  reply	other threads:[~2019-10-09 12:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 13:44 Christian Brauner
2019-10-08 14:14 ` Christian Brauner
2019-10-08 14:20 ` Adhemerval Zanella
2019-10-09 10:48   ` Christian Brauner
2019-10-09 11:04     ` Florian Weimer
2019-10-09 11:12       ` Christian Brauner
2019-10-09 11:56         ` Florian Weimer
2019-10-09 11:58           ` Christian Brauner
2019-10-09 12:01             ` Florian Weimer [this message]
2019-10-09 13:33               ` Christian Brauner
2019-10-10 10:51                 ` Christian Brauner
2019-10-10 14:49                   ` Florian Weimer
2019-10-11 10:47                     ` Christian Brauner
2019-10-09 11:14       ` Dmitry V. Levin
2019-12-04 13:16 ` clone3: CLONE_CLEAR_SIGHAND v5.5 Christian Brauner
2019-12-04 13:45   ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9syyvpd.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).