public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Move ____longjmp_chk prototype to include/setjmp.h
@ 2017-08-20  0:25 H.J. Lu
  2017-08-20  7:38 ` Florian Weimer
  0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2017-08-20  0:25 UTC (permalink / raw)
  To: GNU C Library

Move ____longjmp_chk prototype to include/setjmp.h and add
attribute_hidden.

OK for master?

H.J.
--
	* debug/longjmp_chk.c (____longjmp_chk): Moved to ...
	* include/setjmp.h (____longjmp_chk): Here.  Add
	attribute_hidden.
---
 debug/longjmp_chk.c | 4 ----
 include/setjmp.h    | 3 +++
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/debug/longjmp_chk.c b/debug/longjmp_chk.c
index 1a927f5ac1..1cea6c05ef 100644
--- a/debug/longjmp_chk.c
+++ b/debug/longjmp_chk.c
@@ -17,10 +17,6 @@
 
 #include <setjmp.h>
 
-// XXX Should move to include/setjmp.h
-extern void ____longjmp_chk (__jmp_buf __env, int __val)
-     __attribute__ ((__noreturn__));
-
 #define __longjmp ____longjmp_chk
 #define __libc_siglongjmp __longjmp_chk
 
diff --git a/include/setjmp.h b/include/setjmp.h
index 90f46976e3..e45328b18a 100644
--- a/include/setjmp.h
+++ b/include/setjmp.h
@@ -8,6 +8,9 @@
 extern void __longjmp (__jmp_buf __env, int __val)
      __attribute__ ((__noreturn__)) attribute_hidden;
 
+extern void ____longjmp_chk (__jmp_buf __env, int __val)
+     __attribute__ ((__noreturn__)) attribute_hidden;
+
 /* Internal function to possibly save the current mask of blocked signals
    in ENV, and always set the flag saying whether or not it was saved.
    This is used by the machine-dependent definition of `__sigsetjmp'.
-- 
2.13.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Move ____longjmp_chk prototype to include/setjmp.h
  2017-08-20  0:25 [PATCH] Move ____longjmp_chk prototype to include/setjmp.h H.J. Lu
@ 2017-08-20  7:38 ` Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2017-08-20  7:38 UTC (permalink / raw)
  To: H.J. Lu; +Cc: GNU C Library

* H. J. Lu:

> 	* debug/longjmp_chk.c (____longjmp_chk): Moved to ...
> 	* include/setjmp.h (____longjmp_chk): Here.  Add
> 	attribute_hidden.

Looks good.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-20  7:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-20  0:25 [PATCH] Move ____longjmp_chk prototype to include/setjmp.h H.J. Lu
2017-08-20  7:38 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).