From: Andreas Schwab <schwab@linux-m68k.org>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Consolidate Linux mmap implementation
Date: Fri, 24 Mar 2017 17:42:00 -0000 [thread overview]
Message-ID: <87vaqy372c.fsf@linux-m68k.org> (raw)
In-Reply-To: <1490369962-29989-1-git-send-email-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Fri, 24 Mar 2017 12:39:22 -0300")
On Mär 24 2017, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> +void *
> +__mmap (void *addr, size_t len, int prot, int flags, int fd, off_t offset)
> +{
> + MMAP_CHECK_PAGE_UNIT
I think it would be better to define this as a function style macro.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2017-03-24 17:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 15:39 Adhemerval Zanella
2017-03-24 17:42 ` Andreas Schwab [this message]
2017-03-24 17:57 ` Adhemerval Zanella
2017-04-06 20:00 ` Adhemerval Zanella
2017-04-12 12:44 ` Adhemerval Zanella
2017-04-12 14:03 ` Florian Weimer
2017-04-12 14:15 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaqy372c.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).