public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: Gabi Falk <gabifalk@gmx.com>
Cc: libc-alpha@sourceware.org,  "H.J. Lu" <hjl.tools@gmail.com>,
	 Florian Weimer <fweimer@redhat.com>,
	 "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH 0/3] i586/i686: Fix multiple definitions in libc.a
Date: Thu, 02 May 2024 11:52:20 +0100	[thread overview]
Message-ID: <87wmoccwpn.fsf@gentoo.org> (raw)
In-Reply-To: <20240430200506.2717717-1-gabifalk@gmx.com> (Gabi Falk's message of "Tue, 30 Apr 2024 20:05:01 +0000")

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Gabi Falk <gabifalk@gmx.com> writes:

> This patch fixes two issues related to multiple definitions of functions
> in the static library built as PIC and adds a test to prevent such
> issues from occurring in the future.
>
> Gabi Falk (3):
>   i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk
>   i686: Fix multiple definitions of __memmove_chk and __memset_chk
>   Add a test to check for duplicate definitions in the static library

Thanks! Pushed with Tested-by for the i686 commit specifically too.

>
>  Makefile                    | 7 +++++++
>  sysdeps/i386/i586/memcpy.S  | 2 +-
>  sysdeps/i386/i686/memmove.S | 2 +-
>  sysdeps/i386/i686/memset.S  | 2 +-
>  4 files changed, 10 insertions(+), 3 deletions(-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]

      parent reply	other threads:[~2024-05-02 10:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 20:05 Gabi Falk
2024-04-30 20:05 ` [PATCH 1/3] i586: Fix multiple definitions of __memcpy_chk and __mempcpy_chk Gabi Falk
2024-04-30 20:11   ` H.J. Lu
2024-04-30 20:05 ` [PATCH 2/3] i686: Fix multiple definitions of __memmove_chk and __memset_chk Gabi Falk
2024-04-30 20:12   ` H.J. Lu
2024-04-30 20:05 ` [PATCH 3/3] Add a test to check for duplicate definitions in the static library Gabi Falk
2024-04-30 20:12   ` H.J. Lu
2024-05-01  0:01 ` [PATCH 0/3] i586/i686: Fix multiple definitions in libc.a Dmitry V. Levin
2024-05-02 10:52 ` Sam James [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmoccwpn.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=fweimer@redhat.com \
    --cc=gabifalk@gmx.com \
    --cc=hjl.tools@gmail.com \
    --cc=ldv@altlinux.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).