From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 01247384AB4A for ; Thu, 25 Apr 2024 15:00:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01247384AB4A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 01247384AB4A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714057234; cv=none; b=l77y5+j4EtLat5oGqWvC8h4o3niaYQBNXsF5glAnqAScjwpPXrqRW6HpcLLy8LUPo+J97xEvdn93KM5ciBH11tHBALrh9KSRgtXOpLOseVsfc0F308DtQVhj8oBN75dWLB+/0e/YIucuyZD2mu/OiVkE9PpJvBgEHBeuS6dBaHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714057234; c=relaxed/simple; bh=oSqzkPsgMOAhJsAqiZd7x+aZ/lZJ7MTu4a73Av8rnpA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=P5exiEf/KuaP8N6cBIASDUZyj9hH9RRJgz+qCFnI9igq2Zv5cZwj9yaLZtJD/Q2LWmEZqhhaK3atkK1iixaZgZevndSPXOkrYahbi+/YIB57uUVDdPpYm/rs5o3sJxQMf1hHAvuyoEGxo7rupyu8OybLwWciiPZ8P0nFOPRUBHQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714057229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8B/URNd5GlC38yfe9TxK8qKakPM66P3xyrw044/zr9I=; b=C1D1TYUHiyZasu+iJxV6G2XdliLvOFY66pisxP2Q3FM+XdKKBZrRTzftGFLIi1M+XyC0gq 6p0G1qiUgWKaFlJCUWlaKs6+wzOJSxi+SYJ66EmTHegmlO9h8H6852hMhmF7rPf5ucUqoe PovkE/X+dnvBtAWCE+CJMe0CwOYNPsI= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-146-pU3ETjD1OaaV1C8Zu1wFTQ-1; Thu, 25 Apr 2024 11:00:28 -0400 X-MC-Unique: pU3ETjD1OaaV1C8Zu1wFTQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CEF2F1C05155; Thu, 25 Apr 2024 15:00:27 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.74]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0240B112131D; Thu, 25 Apr 2024 15:00:26 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2] elf: Also compile dl-misc.os with $(rtld-early-cflags) In-Reply-To: <20240425145425.309747-1-hjl.tools@gmail.com> (H. J. Lu's message of "Thu, 25 Apr 2024 07:54:24 -0700") References: <20240425145425.309747-1-hjl.tools@gmail.com> Date: Thu, 25 Apr 2024 17:00:25 +0200 Message-ID: <87wmol4hdi.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: > Also compile dl-misc.os with $(rtld-early-cflags) to avoid > > Program received signal SIGILL, Illegal instruction. > 0x00007ffff7fd36ea in _dl_strtoul (nptr=nptr@entry=0x7fffffffe2c9 "2", > endptr=endptr@entry=0x7fffffffd728) at dl-misc.c:156 > 156 bool positive = true; > (gdb) bt > #0 0x00007ffff7fd36ea in _dl_strtoul (nptr=nptr@entry=0x7fffffffe2c9 "2", > endptr=endptr@entry=0x7fffffffd728) at dl-misc.c:156 > #1 0x00007ffff7fdb1a9 in tunable_initialize ( > cur=cur@entry=0x7ffff7ffbc00 , > strval=strval@entry=0x7fffffffe2c9 "2", len=len@entry=1) > at dl-tunables.c:131 > #2 0x00007ffff7fdb3a2 in parse_tunables (valstring=) > at dl-tunables.c:258 > #3 0x00007ffff7fdb5d9 in __GI___tunables_init (envp=0x7fffffffdd58) > at dl-tunables.c:288 > #4 0x00007ffff7fe44c3 in _dl_sysdep_start ( > start_argptr=start_argptr@entry=0x7fffffffdcb0, > dl_main=dl_main@entry=0x7ffff7fe5f80 ) > at ../sysdeps/unix/sysv/linux/dl-sysdep.c:110 > #5 0x00007ffff7fe5cae in _dl_start_final (arg=0x7fffffffdcb0) at rtld.c:494 > #6 _dl_start (arg=0x7fffffffdcb0) at rtld.c:581 > #7 0x00007ffff7fe4b38 in _start () > (gdb) > > when glibc is compiled with APX. Maybe mention setting GLIBC_TUNABLES as the trigger in the commit message? Otherwise: Reviewed-by: Florian Weimer Thanks, Florian