public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Tulio Magno Quites Machado Filho via Libc-alpha
	<libc-alpha@sourceware.org>
Cc: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
Subject: Re: [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550]
Date: Thu, 22 Jun 2023 12:55:35 +0200	[thread overview]
Message-ID: <87wmzv3gwo.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230613215633.3179708-1-tuliom@ascii.art.br> (Tulio Magno Quites Machado Filho via Libc-alpha's message of "Tue, 13 Jun 2023 18:56:33 -0300")

* Tulio Magno Quites Machado Filho via Libc-alpha:

> From: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
>
> GCC was the only compiler affected by the issue with
> __builtin_isinf_sign and float128.
>
> Fix BZ #30550.
> ---
>  math/math.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/math/math.h b/math/math.h
> index 6427c72276..f13639943e 100644
> --- a/math/math.h
> +++ b/math/math.h
> @@ -1015,7 +1015,8 @@ enum
>  
>  /* Return nonzero value if X is positive or negative infinity.  */
>  # if __HAVE_DISTINCT_FLOAT128 && !__GNUC_PREREQ (7,0) \
> -     && !defined __SUPPORT_SNAN__ && !defined __cplusplus
> +     && !defined __SUPPORT_SNAN__ && !defined __cplusplus \
> +     && !defined __clang__
>     /* Since __builtin_isinf_sign is broken for float128 before GCC 7.0,
>        use the helper function, __isinff128, with older compilers.  This is
>        only provided for C mode, because in C++ mode, GCC has no support

This looks okay to me.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


  reply	other threads:[~2023-06-22 10:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13 21:56 Tulio Magno Quites Machado Filho
2023-06-22 10:55 ` Florian Weimer [this message]
2023-06-30 22:15   ` Tulio Magno Quites Machado Filho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmzv3gwo.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=tuliom@ascii.art.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).