From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7DDE93858D37 for ; Thu, 22 Jun 2023 10:55:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DDE93858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687431340; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kwUotGWEOIyXr6NZeaHQ4UHH6KouzuqlUlLVIrcskh0=; b=QGoDuGhqzik68dU0dYCC9uJlcouFRmfPvD0h+aVK81WRRaIS8nwyLR3eJ6nX+Px541Mjcq IUYJtmPhEt3pKqhIBkK6NyaZTrFdtulPV4r7UENly73pykVyWJr5ftMr1RaBlcq5p92kHd XEGKh+2n7kVzr1swznA4PvLxw2WsAp0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-372-4VzfRjVeO4ey-T9knm0SWg-1; Thu, 22 Jun 2023 06:55:38 -0400 X-MC-Unique: 4VzfRjVeO4ey-T9knm0SWg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 564A22804611; Thu, 22 Jun 2023 10:55:38 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 81D7A492C13; Thu, 22 Jun 2023 10:55:37 +0000 (UTC) From: Florian Weimer To: Tulio Magno Quites Machado Filho via Libc-alpha Cc: Tulio Magno Quites Machado Filho Subject: Re: [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550] References: <20230613215633.3179708-1-tuliom@ascii.art.br> Date: Thu, 22 Jun 2023 12:55:35 +0200 In-Reply-To: <20230613215633.3179708-1-tuliom@ascii.art.br> (Tulio Magno Quites Machado Filho via Libc-alpha's message of "Tue, 13 Jun 2023 18:56:33 -0300") Message-ID: <87wmzv3gwo.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Tulio Magno Quites Machado Filho via Libc-alpha: > From: Tulio Magno Quites Machado Filho > > GCC was the only compiler affected by the issue with > __builtin_isinf_sign and float128. > > Fix BZ #30550. > --- > math/math.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/math/math.h b/math/math.h > index 6427c72276..f13639943e 100644 > --- a/math/math.h > +++ b/math/math.h > @@ -1015,7 +1015,8 @@ enum > > /* Return nonzero value if X is positive or negative infinity. */ > # if __HAVE_DISTINCT_FLOAT128 && !__GNUC_PREREQ (7,0) \ > - && !defined __SUPPORT_SNAN__ && !defined __cplusplus > + && !defined __SUPPORT_SNAN__ && !defined __cplusplus \ > + && !defined __clang__ > /* Since __builtin_isinf_sign is broken for float128 before GCC 7.0, > use the helper function, __isinff128, with older compilers. This is > only provided for C mode, because in C++ mode, GCC has no support This looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian