* [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550]
@ 2023-06-13 21:56 Tulio Magno Quites Machado Filho
2023-06-22 10:55 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2023-06-13 21:56 UTC (permalink / raw)
To: libc-alpha
From: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
GCC was the only compiler affected by the issue with
__builtin_isinf_sign and float128.
Fix BZ #30550.
---
math/math.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/math/math.h b/math/math.h
index 6427c72276..f13639943e 100644
--- a/math/math.h
+++ b/math/math.h
@@ -1015,7 +1015,8 @@ enum
/* Return nonzero value if X is positive or negative infinity. */
# if __HAVE_DISTINCT_FLOAT128 && !__GNUC_PREREQ (7,0) \
- && !defined __SUPPORT_SNAN__ && !defined __cplusplus
+ && !defined __SUPPORT_SNAN__ && !defined __cplusplus \
+ && !defined __clang__
/* Since __builtin_isinf_sign is broken for float128 before GCC 7.0,
use the helper function, __isinff128, with older compilers. This is
only provided for C mode, because in C++ mode, GCC has no support
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550]
2023-06-13 21:56 [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550] Tulio Magno Quites Machado Filho
@ 2023-06-22 10:55 ` Florian Weimer
2023-06-30 22:15 ` Tulio Magno Quites Machado Filho
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2023-06-22 10:55 UTC (permalink / raw)
To: Tulio Magno Quites Machado Filho via Libc-alpha
Cc: Tulio Magno Quites Machado Filho
* Tulio Magno Quites Machado Filho via Libc-alpha:
> From: Tulio Magno Quites Machado Filho <tuliom@redhat.com>
>
> GCC was the only compiler affected by the issue with
> __builtin_isinf_sign and float128.
>
> Fix BZ #30550.
> ---
> math/math.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/math/math.h b/math/math.h
> index 6427c72276..f13639943e 100644
> --- a/math/math.h
> +++ b/math/math.h
> @@ -1015,7 +1015,8 @@ enum
>
> /* Return nonzero value if X is positive or negative infinity. */
> # if __HAVE_DISTINCT_FLOAT128 && !__GNUC_PREREQ (7,0) \
> - && !defined __SUPPORT_SNAN__ && !defined __cplusplus
> + && !defined __SUPPORT_SNAN__ && !defined __cplusplus \
> + && !defined __clang__
> /* Since __builtin_isinf_sign is broken for float128 before GCC 7.0,
> use the helper function, __isinff128, with older compilers. This is
> only provided for C mode, because in C++ mode, GCC has no support
This looks okay to me.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550]
2023-06-22 10:55 ` Florian Weimer
@ 2023-06-30 22:15 ` Tulio Magno Quites Machado Filho
0 siblings, 0 replies; 3+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2023-06-30 22:15 UTC (permalink / raw)
To: Florian Weimer, Tulio Magno Quites Machado Filho via Libc-alpha
Cc: Qiu Chaofan
Florian Weimer <fweimer@redhat.com> writes:
> This looks okay to me.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
I added the Reported-by that I had forgotten to add initially and pushed
this as 0a9e93842d8e535ac8174cb4ff7fb830b20e4ae7.
Thanks!
--
Tulio Magno
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-30 22:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 21:56 [PATCH] Stop applying a GCC-specific workaround on clang [BZ #30550] Tulio Magno Quites Machado Filho
2023-06-22 10:55 ` Florian Weimer
2023-06-30 22:15 ` Tulio Magno Quites Machado Filho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).