From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 961D13857351 for ; Thu, 29 Sep 2022 17:31:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 961D13857351 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend03.mail.m-online.net (unknown [192.168.6.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4MdgPt0TPrz1s89K; Thu, 29 Sep 2022 19:31:12 +0200 (CEST) Received: from localhost (dynscan3.mnet-online.de [192.168.6.84]) by mail.m-online.net (Postfix) with ESMTP id 4MdgPr6Qf3z1qqlR; Thu, 29 Sep 2022 19:31:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new, port 10024) with ESMTP id BoXpVZb789tE; Thu, 29 Sep 2022 19:31:12 +0200 (CEST) X-Auth-Info: P+t5yTNEDXt7pjlxtukZscEGS8uF33Y98F+3wLmeO+3nNcKC0d9X6voVl0sfE2gj Received: from igel.home (dynamic-046-114-002-140.46.114.pool.telefonica.de [46.114.2.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 29 Sep 2022 19:31:12 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 8DEB52C25FF; Thu, 29 Sep 2022 19:31:11 +0200 (CEST) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Cc: Wilco Dijkstra , Yu Chien Peter Lin , Adhemerval Zanella Subject: Re: [PATCH] malloc: Do not clobber errno on __getrandom_nocancel (BZ#29624) References: <20220929164510.3454281-1-adhemerval.zanella@linaro.org> X-Yow: .. Now I think I just reached the state of HYPERTENSION that comes JUST BEFORE you see the TOTAL at the SAFEWAY CHECKOUT COUNTER! Date: Thu, 29 Sep 2022 19:31:11 +0200 In-Reply-To: <20220929164510.3454281-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 29 Sep 2022 13:45:10 -0300") Message-ID: <87wn9mozog.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sep 29 2022, Adhemerval Zanella via Libc-alpha wrote: > @@ -51,7 +51,7 @@ __arc4random_buf (void *p, size_t n) > n -= l; > continue; /* Interrupted by a signal; keep going. */ > } > - else if (l < 0 && errno == ENOSYS) > + else if (l < 0 && l == -ENOSYS) This is a redundant condition. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."