From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3D66F3858403 for ; Thu, 22 Sep 2022 12:14:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3D66F3858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663848847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dcwrmosj+C3/udlTxyjwYSHHXKC1taSESU3weHG8nEw=; b=EHqJS6mZu97CKMBoKAKwD1bFUImfJpbGU7cAWbqyeyPQROHhpE7R/OoCSfxo5PtJNQ0i+4 jm92MW0peYRWBZ6dK0aJbMsTSQOTytDrQUDdp8NXJeqaoesDLu+U1ijtBKPQJWjRnWCTYO cYYJpRHlR0zcZjLszMYWl5fBVInHeAU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-75-Euv4SGOjNcWKNrLrQBTB-A-1; Thu, 22 Sep 2022 08:14:04 -0400 X-MC-Unique: Euv4SGOjNcWKNrLrQBTB-A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9273C294EDF4; Thu, 22 Sep 2022 12:14:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D51072027061; Thu, 22 Sep 2022 12:14:03 +0000 (UTC) From: Florian Weimer To: Javier Pello Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 2/6] elf: Remove legacy hwcaps support from ldconfig References: <20220905200652.d69204581d15c64647da5cd2@otheo.eu> <87h71l9crb.fsf@oldenburg.str.redhat.com> <20220906201207.e7b3d08272af5649754e76b1@otheo.eu> <87h71i6rfa.fsf@oldenburg.str.redhat.com> <20220914200724.8e685fbbaf441c96d19011c6@otheo.eu> <20220917161748.2b76e1731a27eb78880ee57c@otheo.eu> <20220917161949.c555288a52d870ef80b95126@otheo.eu> Date: Thu, 22 Sep 2022 14:14:02 +0200 In-Reply-To: <20220917161949.c555288a52d870ef80b95126@otheo.eu> (Javier Pello's message of "Sat, 17 Sep 2022 16:19:49 +0200") Message-ID: <87wn9vmws5.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Javier Pello: > Remove support for the legacy hwcaps subdirectories from ldconfig. > > Signed-off-by: Javier Pello > --- > elf/ldconfig.c | 149 +++---------------------------------------------- > 1 file changed, 8 insertions(+), 141 deletions(-) > > diff --git a/elf/ldconfig.c b/elf/ldconfig.c > index 6f37f38f..9399c228 100644 > --- a/elf/ldconfig.c > +++ b/elf/ldconfig.c > @@ -46,16 +46,6 @@ > @@ -813,9 +719,7 @@ search_dir (const struct dir_entry *entry) > subdirectory)? The dynamic linker is also considered as > shared library. */ > if (!_dl_is_dso (direntry->d_name) > - && (direntry->d_type == DT_REG > - || (entry->hwcaps == NULL > - && !is_hwcap_platform (direntry->d_name)))) > + && (direntry->d_type == DT_REG || entry->hwcaps == NULL)) > continue; > The comment needs updating. Rest looks okay. Thanks, Florian