From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5C9843857C5D for ; Fri, 22 Jul 2022 12:35:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5C9843857C5D Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-479-CMe2TxiZN96EakxoLvybMw-1; Fri, 22 Jul 2022 08:35:14 -0400 X-MC-Unique: CMe2TxiZN96EakxoLvybMw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5EAF32919EA2; Fri, 22 Jul 2022 12:35:14 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.94]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 490D6492CA5; Fri, 22 Jul 2022 12:35:13 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, Carlos O'Donell , Szabolcs Nagy , Yann Droneaud Subject: Re: [PATCH v12 1/9] stdlib: Add arc4random, arc4random_buf, and arc4random_uniform (BZ #4417) References: <20220722122137.3270666-1-adhemerval.zanella@linaro.org> <20220722122137.3270666-2-adhemerval.zanella@linaro.org> Date: Fri, 22 Jul 2022 14:35:11 +0200 In-Reply-To: <20220722122137.3270666-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Fri, 22 Jul 2022 09:21:29 -0300") Message-ID: <87wnc5e35s.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2022 12:35:19 -0000 * Adhemerval Zanella: > diff --git a/stdlib/chacha20.c b/stdlib/chacha20.c > new file mode 100644 > index 0000000000..77e37655cd > --- /dev/null > +++ b/stdlib/chacha20.c > @@ -0,0 +1,179 @@ > +static void > +chacha20_crypt (uint32_t *state, uint8_t *dst, const uint8_t *src) > +{ > + size_t bytes = CHACHA20_BUFSIZE; > + while (bytes >= CHACHA20_BLOCK_SIZE) That doesn't look right. No bytes variable. The chacha20_crypt functions should probably use arguments in the style of uint8_t dst[static CHACHA20_BUFSIZE] for compiler size checking. Thanks, Florian