From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3ED8B3858C2C for ; Fri, 22 Apr 2022 08:34:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3ED8B3858C2C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-GUfW71h5O4alkVMm2fPQUw-1; Fri, 22 Apr 2022 04:34:26 -0400 X-MC-Unique: GUfW71h5O4alkVMm2fPQUw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 08FC980B710; Fri, 22 Apr 2022 08:34:26 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.187]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 30E3640D0174; Fri, 22 Apr 2022 08:34:25 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 2/2] Default to --with-default-link=no (bug 25812) References: <15c7f6e9afe2c2b9c51ebc6372682a39b0932712.1649691083.git.fweimer@redhat.com> <87a6cdtykm.fsf@oldenburg.str.redhat.com> <871qxpttij.fsf@oldenburg.str.redhat.com> <2629dfeb-0339-1598-3534-74ed6ca8df26@gotplt.org> Date: Fri, 22 Apr 2022 10:34:23 +0200 In-Reply-To: <2629dfeb-0339-1598-3534-74ed6ca8df26@gotplt.org> (Siddhesh Poyarekar's message of "Fri, 22 Apr 2022 14:02:48 +0530") Message-ID: <87wnfhsei8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 08:34:29 -0000 * Siddhesh Poyarekar: > On 22/04/2022 13:54, Florian Weimer wrote: >> * Siddhesh Poyarekar: >> >>>>> I wonder if we should put this in the python environment for all glibc >>>>> python scripts. Only a soft suggestion though since this is just the >>>>> first module usage. Maybe as and when we port other such tests to >>>>> this module we should rethink this. >> >>>> We set PYTHONPATH in the makefiles in many cases. I did this mostly >>>> for development. >>> >>> Indeed, in fact we have py-env in Rules which may be helpful. How >>> about using it the invocation instead of the above then? >> I do like that I can run the script directly. 8-) > > Fair enough :) So it's good to install along with the glibcelf.py patch? Thanks, Florian