From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] x86-64: Remove LD_PREFER_MAP_32BIT_EXEC support [BZ #28656]
Date: Fri, 10 Dec 2021 22:59:50 +0100 [thread overview]
Message-ID: <87wnkc2ka1.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20211210215550.2546508-1-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 10 Dec 2021 13:55:50 -0800")
* H. J. Lu:
> Remove the LD_PREFER_MAP_32BIT_EXEC environment variable support since
> the first PT_LOAD segment is no longer executable due to defaulting to
> -z separate-code.
>
> This fixes [BZ #28656].
> ---
> NEWS | 4 ++
> .../unix/sysv/linux/x86_64/64/dl-librecon.h | 45 -------------------
> .../unix/sysv/linux/x86_64/64/mmap_internal.h | 42 -----------------
> sysdeps/x86/cpu-tunables.c | 7 ---
> ...cpu-features-preferred_feature_index_1.def | 1 -
> 5 files changed, 4 insertions(+), 95 deletions(-)
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/64/dl-librecon.h
> delete mode 100644 sysdeps/unix/sysv/linux/x86_64/64/mmap_internal.h
Patch looks good to me.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
next prev parent reply other threads:[~2021-12-10 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 21:55 H.J. Lu
2021-12-10 21:59 ` Florian Weimer [this message]
2021-12-13 23:10 ` Joseph Myers
2021-12-14 0:35 ` [PATCH] NEWS: Move LD_PREFER_MAP_32BIT_EXEC H.J. Lu
2021-12-14 8:43 ` Andreas Schwab
2021-12-14 15:22 ` [PATCH] NEWS: Document LD_PREFER_MAP_32BIT_EXEC as x86-64 only H.J. Lu
2021-12-14 15:41 ` Andreas Schwab
2021-12-14 15:59 ` [PATCH v2] " H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnkc2ka1.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).