From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH 15/30] nptl: Remove pread from libpthread
Date: Wed, 17 Mar 2021 21:04:03 +0100 [thread overview]
Message-ID: <87wnu5wnrg.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <986f7915-13ad-97d8-230d-797000c6c397@linaro.org> (Adhemerval Zanella's message of "Wed, 17 Mar 2021 16:47:07 -0300")
* Adhemerval Zanella:
>> Sorry, two more things: I don't quite see how alpha is an outlier here.
>>
>> And ideally, this should receive the same treatment (and similar commit
>> message) as lseek64 because I think we should switch from GLIBC_2.2
>> symbols to GLIBC_2.1 for the default, and make the GLIBC_2.2 symbols
>> compat versions.
>>
>> Both comments apply to the pwrite change as well.
>
> Alpha is outlier because it requires to handle a GLIBC_2_1 and
> GLIBC_2_2 symbol versioning *also* for pread and __pread (not only
> for LFS pread64 and __pread64 as usual LFS ABIs).
Ah I see it now: mips64-linux-gnu-n64 has only this:
1556: 0000000000109b70 300 FUNC GLOBAL DEFAULT 12 __libc_pread@@GLIBC_PRIVATE
2229: 0000000000109b70 300 FUNC WEAK DEFAULT 12 pread@@GLIBC_2.2
Likewise ia64-linux-gnu:
1640: 00000000001bb180 528 FUNC GLOBAL DEFAULT 11 __libc_pread@@GLIBC_PRIVATE
2624: 00000000001bb180 528 FUNC WEAK DEFAULT 11 pread@@GLIBC_2.2
While i686-linux-gnu has:
1327: 000f8480 218 FUNC GLOBAL DEFAULT 13 __libc_pread@@GLIBC_PRIVATE
2371: 000f8480 218 FUNC GLOBAL DEFAULT 13 pread@@GLIBC_2.2
2373: 000f8480 218 FUNC GLOBAL DEFAULT 13 pread@GLIBC_2.1
And alpha-linux-gnu has:
1406: 00000000000fc490 296 FUNC GLOBAL DEFAULT 11 __libc_pread@@GLIBC_PRIVATE
2522: 00000000000fc490 296 FUNC GLOBAL DEFAULT 11 pread@@GLIBC_2.2
2524: 00000000000fc490 296 FUNC GLOBAL DEFAULT 11 pread@GLIBC_2.1
I compared it to the 32-bit ports …
It's a bit unfortunate that we have to pollute the generic code for
this. But I don't see a way to avoid this if we bias the symbol version
towards pread@@GLIBC_2.1, to avoid the new pread@@GLIBC_2.34 symbol.
Thanks,
Florian
next prev parent reply other threads:[~2021-03-17 20:04 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 20:04 [PATCH 00/30] libpthread removal: pthread-compat-wrappers and other libc symbols Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 01/30] nptl: Remove write from libpthread Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 02/30] nptl: Remove read " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 03/30] nptl: Remove close " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 04/30] nptl: Remove accept " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 05/30] nptl: Remove connect " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 06/30] nptl: Remove recv " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 07/30] nptl: Remove recvfrom " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 08/30] nptl: Remove send " Adhemerval Zanella
2021-03-17 18:07 ` Florian Weimer
2021-03-17 20:13 ` Florian Weimer
2021-03-16 20:04 ` [PATCH 09/30] nptl: Remove sendto " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 10/30] nptl: Remove fsync " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 11/30] nptl: Remove lseek " Adhemerval Zanella
2021-03-17 10:10 ` Florian Weimer
2021-03-17 11:29 ` Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 12/30] nptl: Remove msync " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 13/30] nptl: Remove open " Adhemerval Zanella
2021-03-17 20:11 ` Florian Weimer
2021-03-16 20:04 ` [PATCH 14/30] nptl: Remove pause " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 15/30] nptl: Remove pread " Adhemerval Zanella
2021-03-17 19:33 ` Florian Weimer
2021-03-17 19:35 ` Adhemerval Zanella
2021-03-18 9:52 ` Florian Weimer
2021-03-17 19:41 ` Florian Weimer
2021-03-17 19:47 ` Adhemerval Zanella
2021-03-17 20:04 ` Florian Weimer [this message]
2021-03-17 21:11 ` Joseph Myers
2021-03-18 10:09 ` Florian Weimer
2021-03-19 12:34 ` Adhemerval Zanella
2021-03-19 13:40 ` Florian Weimer
2021-03-19 16:51 ` Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 16/30] nptl: Remove pwrite " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 17/30] nptl: Remove tcdrain " Adhemerval Zanella
2021-03-16 20:04 ` [PATCH 18/30] nptl: Remove msgrcv " Adhemerval Zanella
2021-03-17 18:15 ` Florian Weimer
2021-03-16 20:04 ` [PATCH 19/30] nptl: Remove msgsnd " Adhemerval Zanella
2021-03-17 18:16 ` Florian Weimer
2021-03-16 20:05 ` [PATCH 20/30] nptl: Remove sigwait " Adhemerval Zanella
2021-03-16 20:05 ` [PATCH 21/30] nptl: Remove sigsuspend " Adhemerval Zanella
2021-03-17 18:17 ` Florian Weimer
2021-03-16 20:05 ` [PATCH 22/30] nptl: Remove recvmsg " Adhemerval Zanella
2021-03-16 20:05 ` [PATCH 23/30] nptl: Remove sendmsg " Adhemerval Zanella
2021-03-16 20:05 ` [PATCH 24/30] nptl: Move fcntl " Adhemerval Zanella
2021-03-16 20:05 ` [PATCH 25/30] nptl: Move pthread_kill to libc Adhemerval Zanella
2021-03-17 18:30 ` Florian Weimer
2021-03-17 18:34 ` Adhemerval Zanella
2021-03-17 19:02 ` Florian Weimer
2021-03-16 20:05 ` [PATCH 26/30] nptl: Remove pthread raise implementation Adhemerval Zanella
2021-03-17 18:35 ` Florian Weimer
2021-03-17 18:40 ` Adhemerval Zanella
2021-03-16 20:05 ` [PATCH 27/30] nptl: Move system to libc Adhemerval Zanella
2021-03-16 20:05 ` [PATCH 28/30] signal: Add __libc_sigaction Adhemerval Zanella
2021-03-17 19:23 ` Florian Weimer
2021-03-16 20:05 ` [PATCH 29/30] nptl: Move sigaction to libc Adhemerval Zanella
2021-03-17 19:02 ` Florian Weimer
2021-03-16 20:05 ` [PATCH 30/30] nptl: Remove __libc_allocate_rtsig, __libc_current_sigrtmax, and __libc_current_sigrtmin Adhemerval Zanella
2021-03-17 19:12 ` Florian Weimer
2021-03-17 14:22 ` [PATCH 00/30] libpthread removal: pthread-compat-wrappers and other libc symbols Florian Weimer
2021-03-17 14:25 ` Adhemerval Zanella
2021-03-17 20:35 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnu5wnrg.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).