From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 1AE5B385481F for ; Wed, 17 Mar 2021 20:04:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1AE5B385481F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-XQOIzZJEP_WdShD_rFVhiA-1; Wed, 17 Mar 2021 16:03:59 -0400 X-MC-Unique: XQOIzZJEP_WdShD_rFVhiA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2FD38189C8; Wed, 17 Mar 2021 20:03:57 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-121.ams2.redhat.com [10.36.115.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 138B360C13; Wed, 17 Mar 2021 20:03:56 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 15/30] nptl: Remove pread from libpthread References: <20210316200510.2135405-1-adhemerval.zanella@linaro.org> <20210316200510.2135405-16-adhemerval.zanella@linaro.org> <87o8fhy3r8.fsf@oldenburg.str.redhat.com> <87k0q5y3cx.fsf@oldenburg.str.redhat.com> <986f7915-13ad-97d8-230d-797000c6c397@linaro.org> Date: Wed, 17 Mar 2021 21:04:03 +0100 In-Reply-To: <986f7915-13ad-97d8-230d-797000c6c397@linaro.org> (Adhemerval Zanella's message of "Wed, 17 Mar 2021 16:47:07 -0300") Message-ID: <87wnu5wnrg.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 20:04:02 -0000 * Adhemerval Zanella: >> Sorry, two more things: I don't quite see how alpha is an outlier here. >>=20 >> And ideally, this should receive the same treatment (and similar commit >> message) as lseek64 because I think we should switch from GLIBC_2.2 >> symbols to GLIBC_2.1 for the default, and make the GLIBC_2.2 symbols >> compat versions. >>=20 >> Both comments apply to the pwrite change as well. > > Alpha is outlier because it requires to handle a GLIBC_2_1 and > GLIBC_2_2 symbol versioning *also* for pread and __pread (not only > for LFS pread64 and __pread64 as usual LFS ABIs). Ah I see it now: mips64-linux-gnu-n64 has only this: 1556: 0000000000109b70 300 FUNC GLOBAL DEFAULT 12 __libc_pread= @@GLIBC_PRIVATE 2229: 0000000000109b70 300 FUNC WEAK DEFAULT 12 pread@@GLIBC= _2.2 Likewise ia64-linux-gnu: 1640: 00000000001bb180 528 FUNC GLOBAL DEFAULT 11 __libc_pread= @@GLIBC_PRIVATE 2624: 00000000001bb180 528 FUNC WEAK DEFAULT 11 pread@@GLIBC= _2.2 While i686-linux-gnu has: 1327: 000f8480 218 FUNC GLOBAL DEFAULT 13 __libc_pread@@GLIBC_= PRIVATE 2371: 000f8480 218 FUNC GLOBAL DEFAULT 13 pread@@GLIBC_2.2 2373: 000f8480 218 FUNC GLOBAL DEFAULT 13 pread@GLIBC_2.1 And alpha-linux-gnu has: 1406: 00000000000fc490 296 FUNC GLOBAL DEFAULT 11 __libc_pread= @@GLIBC_PRIVATE 2522: 00000000000fc490 296 FUNC GLOBAL DEFAULT 11 pread@@GLIBC= _2.2 2524: 00000000000fc490 296 FUNC GLOBAL DEFAULT 11 pread@GLIBC_= 2.1 I compared it to the 32-bit ports =E2=80=A6 It's a bit unfortunate that we have to pollute the generic code for this. But I don't see a way to avoid this if we bias the symbol version towards pread@@GLIBC_2.1, to avoid the new pread@@GLIBC_2.34 symbol. Thanks, Florian