From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 4BDA9385042A for ; Mon, 28 Sep 2020 16:34:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4BDA9385042A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-Ja5FV3j8PW6O8xvIwUCNXA-1; Mon, 28 Sep 2020 12:34:03 -0400 X-MC-Unique: Ja5FV3j8PW6O8xvIwUCNXA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 77BA11018F78; Mon, 28 Sep 2020 16:34:01 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-84.ams2.redhat.com [10.36.114.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2266E78807; Mon, 28 Sep 2020 16:33:58 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Adhemerval Zanella , Robert O'Callahan , "Dmitry V . Levin" Subject: Re: [PATCH 2/6] sysvipc: Return EINVAL for invalid semctl commands References: <20200928144556.239160-1-adhemerval.zanella@linaro.org> <20200928144556.239160-2-adhemerval.zanella@linaro.org> Date: Mon, 28 Sep 2020 18:33:57 +0200 In-Reply-To: <20200928144556.239160-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 28 Sep 2020 11:45:52 -0300") Message-ID: <87wo0d274a.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Sep 2020 16:34:08 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/sysdeps/unix/sysv/linux/semctl.c b/sysdeps/unix/sysv/linux/s= emctl.c > index 1cdabde8f2..dcff6e691d 100644 > --- a/sysdeps/unix/sysv/linux/semctl.c > +++ b/sysdeps/unix/sysv/linux/semctl.c > @@ -158,6 +158,15 @@ __semctl64 (int semid, int semnum, int cmd, ...) > arg64 =3D va_arg (ap, union semun64); > va_end (ap); > break; > + case IPC_RMID: /* arg ignored. */ Missing space after =E2=80=9C.=E2=80=9D. > +/* Return the first invalid command SysV IPC command for shared memory. = */ > +static inline int > +first_shm_invalid_cmd (void) > +{ > + const int shm_cmds[] =3D { > + SHM_STAT, > + SHM_INFO, > +#ifdef SHM_STAT_ANY > + SHM_STAT_ANY, > +#endif > + }; > + > + int invalid =3D first_common_invalid_cmd (); > + for (int i =3D 0; i < array_length (shm_cmds); i++) > + { > + if (invalid =3D=3D shm_cmds[i]) > +=09{ > +=09 invalid++; > +=09 i =3D 0; > +=09} > + } > + > + return invalid; > +} I think this change should go into the shmctl patch? Maybe add the tests separately at the end?=20 Rest looks okay to me. Thanks, Florian --=20 Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'N= eill