From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/3] sunrpc removal
Date: Wed, 08 Jul 2020 15:06:21 +0200 [thread overview]
Message-ID: <87wo3eqhpu.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOrq6HvDdfBRx5OMVHvF8sRWwcLxLr6r44mCmhKQLiJRbQ@mail.gmail.com> (H. J. Lu's message of "Wed, 8 Jul 2020 06:02:10 -0700")
* H. J. Lu:
> On Wed, Jul 8, 2020 at 5:06 AM Florian Weimer via Libc-alpha
> <libc-alpha@sourceware.org> wrote:
>>
>> This patch series polishes Petr Vorel's patches. I think they are ready
>> for inclusion now.
>>
>> I forced the removal for x86-64, and found a bunch of build issues:
>>
>> * bindresvport and the NSS RPC functions need to preserved. The easiest
>> way to do that is to move their implementation to the inet
>> subdirectory, which is what the first patch does.
>>
>> * If sunrpc is gone, __libc_thread_freeres should not call
>> __rpc_thread_destroy anymore.
>>
>> * The cut-off point is glibc 2.31 for the sunrpc removal, not glibc
>
> Did you mean glibc 2.32?
Sorry, it's after 2.31. 2.31 is the version that goes into the
Makefile. It's off by one compared to the compat_symbol version
unfortunately, due to internal complications.
>> 2.28. This affects the csky port (ABI baseline 2.29).
>>
>> The --enable-obsolete-nsl patch deletes more things in this version.
>>
>> I think we should delay merging the --enable-obsolete-rpc removal until
>> the ARC port is merged, along with the required abilist adjustments.
>> But the first two patches do not change the ARC ABI, and could go in
>> now.
>>
>
> I haven't looked at the last 2 patches. But I don't think they should
> wait for the ARC port if they are good to go in. Rebase a port shouldn't
> be that difficult.
I don't have a strong opinion on this.
Thanks,
Florian
prev parent reply other threads:[~2020-07-08 13:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 12:05 Florian Weimer
2020-07-08 12:05 ` [PATCH 1/3] Move non-deprecated RPC-related functions from sunrpc to inet Florian Weimer
2020-07-08 12:21 ` Andreas Schwab
2020-07-08 12:23 ` Florian Weimer
2020-07-08 12:56 ` H.J. Lu
2020-07-08 12:05 ` [PATCH 2/3] Remove --enable-obsolete-nsl configure flag Florian Weimer
2020-07-08 13:16 ` H.J. Lu
2020-07-08 14:55 ` Florian Weimer
2020-07-08 14:57 ` H.J. Lu
2020-07-08 15:22 ` Florian Weimer
2020-07-08 15:23 ` H.J. Lu
2020-07-08 12:06 ` [PATCH 3/3] Remove --enable-obsolete-rpc " Florian Weimer
2020-07-08 13:17 ` H.J. Lu
2020-07-10 9:58 ` Petr Vorel
2020-07-10 10:48 ` Florian Weimer
2020-07-10 10:56 ` Petr Vorel
2020-07-08 13:02 ` [PATCH 0/3] sunrpc removal H.J. Lu
2020-07-08 13:06 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo3eqhpu.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).