From: Florian Weimer <fw@deneb.enyo.de>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/3] rtld: Get architecture specific initializer in rtld_global
Date: Sat, 16 May 2020 19:51:55 +0200 [thread overview]
Message-ID: <87wo5bn4xw.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20200428215243.236312-3-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Tue, 28 Apr 2020 14:52:42 -0700")
* H. J. Lu via Libc-alpha:
> Include <dl-procruntime.c> to get architecture specific initializer in
> rtld_global.
> ---
> elf/rtld.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/elf/rtld.c b/elf/rtld.c
> index 0016db86a7..44b9fb0b3c 100644
> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> @@ -315,6 +315,8 @@ rtld_hidden_def (_dl_starting_up)
> (except those which cannot be added for some reason). */
> struct rtld_global _rtld_global =
> {
> + /* Get architecture specific initializer. */
> +#include <dl-procruntime.c>
> /* Generally the default presumption without further information is an
> * executable stack but this is not true for all platforms. */
> ._dl_stack_flags = DEFAULT_STACK_PERMS,
This patch does not build on its own. I'm surprised that it works in
combination with the third patch.
Is _rtld_global really the right place for this data? Is it even
needed from outside the dynamic loader?
next prev parent reply other threads:[~2020-05-16 17:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:52 [PATCH 0/3] x86: Add --enable-cet=permissive H.J. Lu
2020-04-28 21:52 ` [PATCH 1/3] CET: Rename CET_MAX to CET_CONTROL_MASK [BZ #25887] H.J. Lu
2020-05-16 16:37 ` PING: " H.J. Lu
2020-05-16 17:27 ` Florian Weimer
2020-05-16 23:44 ` [PATCH] x86: Move CET control to _dl_x86_feature_control " H.J. Lu
2020-05-18 7:19 ` Florian Weimer
2020-05-18 12:26 ` V2 " H.J. Lu
2020-05-18 12:36 ` Florian Weimer
2020-04-28 21:52 ` [PATCH 2/3] rtld: Get architecture specific initializer in rtld_global H.J. Lu
2020-05-16 16:38 ` PING: " H.J. Lu
2020-05-16 17:51 ` Florian Weimer [this message]
2020-05-16 18:01 ` H.J. Lu
2020-05-16 18:07 ` Florian Weimer
2020-05-16 18:24 ` V2 [PATCH] " H.J. Lu
2020-04-28 21:52 ` [PATCH 3/3] x86: Add --enable-cet=permissive H.J. Lu
2020-04-29 17:19 ` [PATCH 0/3] " Adhemerval Zanella
2020-04-29 20:29 ` H.J. Lu
2020-04-29 20:46 ` Florian Weimer
2020-04-29 21:14 ` Adhemerval Zanella
2020-05-18 13:50 ` V2 [PATCH] " H.J. Lu
2020-05-18 14:43 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo5bn4xw.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).