From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id 5AE463898529
 for <libc-alpha@sourceware.org>; Thu, 30 Apr 2020 16:53:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5AE463898529
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1jUCRH-0008KR-Ut; Thu, 30 Apr 2020 16:53:31 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1jUCRH-0003Q8-Sd; Thu, 30 Apr 2020 18:53:31 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>,  "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: V3 [PATCH] Add a C wrapper for prctl [BZ #25896]
References: <20200429205217.2435607-1-hjl.tools@gmail.com>
 <87wo5xa0yt.fsf@mid.deneb.enyo.de> <20200430130333.GA254612@gmail.com>
 <87h7x1gkfg.fsf@igel.home> <87mu6t84yg.fsf@mid.deneb.enyo.de>
 <87d07pgjz0.fsf@igel.home>
 <CAMe9rOrbAmipEAKtr-uZvbZxS8BQ1y0s=QjBE=Oc2iS8-w+1kA@mail.gmail.com>
 <878sidgjcp.fsf@igel.home>
 <CAMe9rOok1_-PuzwExk+XZJ_KyE01keNstYAGS9GR9gn6GFHxvg@mail.gmail.com>
Date: Thu, 30 Apr 2020 18:53:31 +0200
In-Reply-To: <CAMe9rOok1_-PuzwExk+XZJ_KyE01keNstYAGS9GR9gn6GFHxvg@mail.gmail.com>
 (H. J. Lu via Libc-alpha's message of "Thu, 30 Apr 2020 08:27:59
 -0700")
Message-ID: <87wo5w7w50.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 16:53:34 -0000

* H. J. Lu via Libc-alpha:

> From ee8672af3ef5f3db438c0abb39b2673944181292 Mon Sep 17 00:00:00 2001
> From: "H.J. Lu" <hjl.tools@gmail.com>
> Date: Wed, 29 Apr 2020 07:38:49 -0700
> Subject: [PATCH] Add a C wrapper for prctl [BZ #25896]
>
> Add a C wrapper to pass arguments in

The commit message is only correct if you drop the .S files.

> /* Control process execution.  */
> extern int prctl (int __option, ...) __THROW;
>
> to prctl syscall:
>
> extern int prctl (int, unsigned long int, unsigned long int,
> 		  unsigned long int, unsigned long int);
>
> On Linux/x86, since the prctl syscall interface:
>
> extern int prctl (int, unsigned long int, unsigned long int,
> 		  unsigned long int, unsigned long int);
>
> and the glibc prctl interface:
>
> extern int prctl (int option, ...);
>
> pass the arguments identically, the assembly verion:
>
> PSEUDO (__prctl, prctl, 5)
> 	ret
> PSEUDO_END (__prctl)
>
> is used.

Doesn't x86 include x32?

Apart from these nits, the patch looks good.  Please settle the matter
of the .S files with Adhemerval. 8-)