From: Florian Weimer <fw@deneb.enyo.de>
To: Stefan Liebler via Libc-alpha <libc-alpha@sourceware.org>
Cc: Stefan Liebler <stli@linux.ibm.com>
Subject: Re: [PATCH glibc 3/9] Implement __libc_early_init
Date: Mon, 27 Apr 2020 15:23:24 +0200 [thread overview]
Message-ID: <87wo61vz8z.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <4b58e00d-4f20-4ca3-1f6d-9d71487d5aaa@linux.ibm.com> (Stefan Liebler via Libc-alpha's message of "Mon, 27 Apr 2020 14:43:44 +0200")
* Stefan Liebler via Libc-alpha:
> I've observed a test fail (make xcheck) with this commit on x86_64/s390x:
>
> nptl/tst-setuid1-static: dl-call-libc-early-init.c:37:
> _dl_call_libc_early_init: Assertion `sym != NULL' failed.
> Didn't expect signal from child: got `Aborted'
>
> Have you already seen this?
I have not. Does this patch fix the failure for you?
The system libc does not yet have __libc_early_init, so it cannot be
loaded by the new, statically linked dlopen.
8<------------------------------------------------------------------8<
Subject: nptl/tst-setuid1-static: Improve isolation from system objects
Static dlopen needs an LD_LIBRARY_PATH setting to avoid loading system
libraries.
-----
nptl/Makefile | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/nptl/Makefile b/nptl/Makefile
index 33fa03807e..ef9a6eb561 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -714,6 +714,11 @@ tst-audit-threads-ENV = LD_AUDIT=$(objpfx)tst-audit-threads-mod1.so
CFLAGS-tst-unwind-thread.c += -funwind-tables
+# The test uses dlopen indirectly and would otherwise load system
+# objects.
+tst-setuid1-static-ENV = \
+ LD_LIBRARY_PATH=$(objpfx):$(common-objpfx):$(common-objpfx)elf
+
# The tests here better do not run in parallel.
ifeq ($(run-built-tests),yes)
ifneq ($(filter %tests,$(MAKECMDGOALS)),)
next prev parent reply other threads:[~2020-04-27 13:23 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 15:56 [PATCH glibc 0/9] Restartable Sequences enablement Mathieu Desnoyers
2020-03-26 15:56 ` [PATCH glibc 1/9] Introduce <elf_machine_sym_no_match.h> Mathieu Desnoyers
2020-04-22 16:27 ` Carlos O'Donell
2020-04-24 18:20 ` Florian Weimer
2020-04-24 20:11 ` Carlos O'Donell
2020-03-26 15:56 ` [PATCH glibc 2/9] Move elf/elf_machine_sym_no_match.h to sysdeps/generic Mathieu Desnoyers
2020-04-22 16:27 ` Carlos O'Donell
2020-03-26 15:56 ` [PATCH glibc 3/9] Implement __libc_early_init Mathieu Desnoyers
2020-04-22 16:28 ` Carlos O'Donell
2020-04-24 18:22 ` Florian Weimer
2020-04-24 20:18 ` Carlos O'Donell
2020-04-27 12:43 ` Stefan Liebler
2020-04-27 13:23 ` Florian Weimer [this message]
2020-04-27 16:23 ` Stefan Liebler
2020-04-27 16:38 ` Florian Weimer
2020-04-27 12:57 ` Adhemerval Zanella
2020-04-27 20:35 ` Carlos O'Donell
2020-03-26 15:56 ` [PATCH glibc 4/9] nptl: Start new threads with all signals blocked [BZ #25098] Mathieu Desnoyers
2020-04-22 17:04 ` Carlos O'Donell
2020-04-24 20:35 ` Florian Weimer
2020-04-26 18:49 ` Carlos O'Donell
2020-04-27 13:11 ` Adhemerval Zanella
2020-03-26 15:56 ` [PATCH glibc 5/9] glibc: Perform rseq(2) registration at C startup and thread creation (v17) Mathieu Desnoyers
2020-04-27 9:11 ` Florian Weimer
2020-04-27 16:40 ` Mathieu Desnoyers
2020-04-27 16:54 ` Florian Weimer
2020-04-27 17:26 ` Mathieu Desnoyers
2020-04-27 20:27 ` Mathieu Desnoyers
2020-04-28 12:02 ` Florian Weimer
2020-04-28 12:33 ` Mathieu Desnoyers
2020-04-28 12:35 ` Florian Weimer
2020-04-28 12:43 ` Mathieu Desnoyers
2020-04-28 12:54 ` Florian Weimer
2020-04-28 14:58 ` Mathieu Desnoyers
2020-04-29 8:16 ` Szabolcs Nagy
2020-04-29 8:18 ` Florian Weimer
2020-04-29 8:52 ` Szabolcs Nagy
2020-04-29 9:01 ` Florian Weimer
2020-04-29 12:57 ` Mathieu Desnoyers
2020-04-30 10:40 ` Szabolcs Nagy
2020-04-30 19:04 ` Mathieu Desnoyers
2020-04-28 12:56 ` Mathieu Desnoyers
2020-04-29 12:19 ` Florian Weimer
2020-04-27 11:59 ` Florian Weimer
2020-04-27 16:47 ` Mathieu Desnoyers
2020-04-27 16:59 ` Florian Weimer
2020-03-26 15:56 ` [PATCH glibc 6/9] glibc: sched_getcpu(): use rseq cpu_id TLS on Linux (v7) Mathieu Desnoyers
2020-04-27 9:13 ` Florian Weimer
2020-03-26 15:56 ` [PATCH glibc 7/9] support record failure: allow use from constructor Mathieu Desnoyers
2020-04-27 16:58 ` Florian Weimer
2020-04-27 17:49 ` Mathieu Desnoyers
2020-03-26 15:56 ` [PATCH glibc 8/9] support: implement xpthread key create/delete (v4) Mathieu Desnoyers
2020-04-27 9:17 ` Florian Weimer
2020-04-27 14:58 ` Mathieu Desnoyers
2020-04-27 15:23 ` Florian Weimer
2020-04-27 15:34 ` Mathieu Desnoyers
2020-04-27 17:00 ` Florian Weimer
2020-04-27 17:30 ` Mathieu Desnoyers
2020-03-26 15:56 ` [PATCH glibc 9/9] rseq registration tests (v9) Mathieu Desnoyers
2020-04-27 16:55 ` Florian Weimer
2020-04-27 17:48 ` Mathieu Desnoyers
2020-04-15 20:45 ` [PATCH glibc 0/9] Restartable Sequences enablement Mathieu Desnoyers
2020-04-22 16:27 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo61vz8z.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).