From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id 233CF384B0C1 for ; Tue, 21 Apr 2020 10:41:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 233CF384B0C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jQqKr-0002Oy-N0; Tue, 21 Apr 2020 10:41:01 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1jQqKr-0000XN-Fi; Tue, 21 Apr 2020 12:41:01 +0200 From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 03/10] linux: Add __readdir_unlocked References: <20200417132209.22065-1-adhemerval.zanella@linaro.org> <20200417132209.22065-3-adhemerval.zanella@linaro.org> Date: Tue, 21 Apr 2020 12:41:01 +0200 In-Reply-To: <20200417132209.22065-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 17 Apr 2020 10:22:02 -0300") Message-ID: <87wo69t936.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 10:41:04 -0000 * Adhemerval Zanella via Libc-alpha: > And use it on readdir_r implementation. I think __readdir_unlocked will not really be async-signal-safe if we have to call malloc during readdir, to allocate the long-to-off64_t translation table for the real fix for bug 23960 (when the kernel does not provide 32-bit off64_t values). That's why I think this change does not go in the right direction, sorry.