From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103835 invoked by alias); 27 Feb 2020 20:58:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 103827 invoked by uid 89); 27 Feb 2020 20:58:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*F:D*br X-HELO: brown.birch.relay.mailchannels.net X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Bitter-Celery: 14e353803b49547f_1582837134153_2746643426 X-MC-Loop-Signature: 1582837134153:1743740177 X-MC-Ingress-Time: 1582837134153 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=ascii.art.br; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=ascii.art.br; bh=zJg3N9KmAxuwGdxbKiJyKUWjx6E=; b= ye8bTufvu0tQVFBCXMLAEosO2tzJssQ1R5YZp2FLs09ZiBcWBYTYcAfGjb1r/r8T M7VlDHzaj+9K9+JsuTiAvIiFmaGTaxZw4AoXctikzpfolMH59XinpEh2Vr476Lqq /CJdwC9yt5nOqxoum/omAfZmCShVzzyB50DF/z1uH1k= X-DH-BACKEND: pdx1-sub0-mail-a8 From: Tulio Magno Quites Machado Filho To: "Paul E. Murphy" , libc-alpha@sourceware.org Cc: Subject: Re: [PATCH 7/7] RFC: ldbl-128ibm-compat: PLT redirects for using ldbl redirects internally In-Reply-To: <20200214161051.32579-8-murphyp@linux.vnet.ibm.com> References: <20200214161051.32579-1-murphyp@linux.vnet.ibm.com> <20200214161051.32579-8-murphyp@linux.vnet.ibm.com> User-Agent: Notmuch/0.29.1 (http://notmuchmail.org) Emacs/26.3 (x86_64-redhat-linux-gnu) Date: Thu, 27 Feb 2020 20:58:00 -0000 Message-ID: <87wo87u4qj.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrleeigddugeduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufgjfhgffffkgggtsehttdertddtredtnecuhfhrohhmpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqeenucfkphepudeikedrudelhedrieeirdduieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghloheprghstghiihdrrghrthdrsghrpdhinhgvthepudeikedrudelhedrieeirdduieefpdhrvghtuhhrnhdqphgrthhhpefvuhhlihhoucforghgnhhoucfsuhhithgvshcuofgrtghhrgguohcuhfhilhhhohcuoehtuhhlihhomhesrghstghiihdrrghrthdrsghrqedpmhgrihhlfhhrohhmpehtuhhlihhomhesrghstghiihdrrghrthdrsghrpdhnrhgtphhtthhopehlihgstgdqrghlphhhrgesshhouhhrtggvfigrrhgvrdhorhhg X-SW-Source: 2020-02/txt/msg01045.txt.bz2 "Paul E. Murphy" writes: > Tweak the PLT bypass magic when building glibc with long double > redirects. This is made more difficult by the fact we only get > one chance to redirect functions. This happens via the public > headers. > > There are roughly three classes of redirect we need to attend to > today: > > 1. Simple redirects, redirected via cdef macro overrides and > and new libc_hidden_ldbl_proto macro. > 2. Internal usage of internal API, e.g __snprintf, which has > no direct analogue. This is bypassed directly on case-by- > case basis. > 3. Double redirects, e.g sscanf and related. These require > a heavier handed approach of macro renaming to existing > symbols. > > Most simple redirects are handled via 1. Ideally, the libc_* > macro would live in libc-symbols.h, but in practice the macros > needed for it to do anything useful live in cdefs.h, so they > are defined in the local override. > > Notably, the internal name of asprintf is renamed to work with > internal prefixed usage. > > This resolves the local plt usage introduced when building glibc > with ldbl == ieee128 on ppc64le. LGTM. Reviewed-by: Tulio Magno Quites Machado Filho -- Tulio Magno