From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org,
Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
Subject: Re: [PATCH 11/12] ldbl-128ibm-compat: Redirect complex math functions
Date: Thu, 21 Jun 2018 19:05:00 -0000 [thread overview]
Message-ID: <87wous9czd.fsf@linux.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1806202055110.31467@digraph.polyomino.org.uk>
Joseph Myers <joseph@codesourcery.com> writes:
> I don't see any test infrastructure in this patch series for either the
> math.h or complex.h functions. Is that to be added separately?
Yes. I was planning to send it with the last patch set as it depends on
other changes to sysdeps/powerpc/powerpc64/le/Makefile.
> Principles include:
>
> * As ulps are currently identified as "ldouble" and "float128", those need
> to be appropriately associated with the correct formats in testing (which
> the testing already handles for getting _FloatN tests using the
> appropriate ulps, whatever type name those ulps may be listed with).
OK.
> * The libm functions built for each format should be tested. While most
> of the functions built for float128 are at least tested under their *f128
> names, you have those such as __significandieee128 which don't have such a
> name and so need testing added for the code to get tested at all.
>
> * There should be at least some test coverage that the redirection works,
> i.e. tests built and run with binary128 long double.
The proposal is to build all ldouble tests twice: one for -mabi=ieeelongdouble
and another for -mabi=ibmlongdouble.
So, I think both of these concerns are covered.
--
Tulio Magno
next prev parent reply other threads:[~2018-06-21 19:05 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 2:04 [PATCHv2 00/12] Introduce ieee128 symbols and redirections Tulio Magno Quites Machado Filho
2018-06-20 2:05 ` [PATCH 07/12] ldbl-128ibm-compat: Provide a scalb implementation Tulio Magno Quites Machado Filho
2018-06-20 20:40 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 04/12] Add a generic significand implementation Tulio Magno Quites Machado Filho
2018-06-20 20:34 ` Joseph Myers
2018-06-20 21:31 ` Tulio Magno Quites Machado Filho
2018-06-21 17:01 ` Joseph Myers
2018-06-22 21:33 ` [PATCH] m68k: Reorganize log1p and significand implementations Tulio Magno Quites Machado Filho
2018-06-22 21:34 ` Jeff Law
2018-06-22 21:54 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 06/12] ldbl-128ibm-compat: Create libm-alias-float128.h Tulio Magno Quites Machado Filho
2018-06-20 20:39 ` Joseph Myers
2018-06-20 22:03 ` Tulio Magno Quites Machado Filho
2018-06-20 2:05 ` [PATCH 01/12] Undefine redirections after long double definition on __LDBL_COMPAT [BZ #23294] Tulio Magno Quites Machado Filho
2018-06-20 10:38 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 03/12] Add a generic scalb implementation Tulio Magno Quites Machado Filho
2018-06-20 20:32 ` Joseph Myers
2018-06-20 22:19 ` Tulio Magno Quites Machado Filho
2018-06-20 22:24 ` Joseph Myers
2018-06-20 2:05 ` [PATCH 02/12] Move declare_mgen_finite_alias definition Tulio Magno Quites Machado Filho
2018-06-20 10:39 ` Joseph Myers
2018-06-20 13:14 ` Tulio Magno Quites Machado Filho
2018-06-20 21:04 ` Joseph Myers
2018-06-20 21:09 ` Tulio Magno Quites Machado Filho
2018-06-20 2:05 ` [PATCH 05/12] Refactor math/bits/math-finite.h, reusing math/bits/mathcalls.h [BZ #23292] Tulio Magno Quites Machado Filho
2018-06-20 10:41 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 11/12] ldbl-128ibm-compat: Redirect complex math functions Tulio Magno Quites Machado Filho
2018-06-20 21:00 ` Joseph Myers
2018-06-21 19:05 ` Tulio Magno Quites Machado Filho [this message]
2018-06-20 2:06 ` [PATCH 12/12] ldbl-128ibm-compat: Provide ieee128 symbols to narrow functions Tulio Magno Quites Machado Filho
2018-06-20 10:55 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 08/12] ldbl-128ibm-compat: Provide a significand implementation Tulio Magno Quites Machado Filho
2018-06-20 20:40 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 09/12] ldbl-128ibm-compat: Provide nexttoward functions Tulio Magno Quites Machado Filho
2018-06-20 20:46 ` Joseph Myers
2018-06-21 1:08 ` Tulio Magno Quites Machado Filho
2018-06-21 16:25 ` Joseph Myers
2018-06-20 2:06 ` [PATCH 10/12] ldbl-128ibm-compat: Redirect long double functions to f128/ieee128 functions Tulio Magno Quites Machado Filho
2018-06-20 20:54 ` Joseph Myers
2018-06-20 22:48 ` Tulio Magno Quites Machado Filho
2018-06-21 16:53 ` [PATCHv2 00/12] Introduce ieee128 symbols and redirections Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wous9czd.fsf@linux.ibm.com \
--to=tuliom@linux.ibm.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=raji@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).