From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50248 invoked by alias); 17 May 2017 21:50:36 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 50232 invoked by uid 89); 17 May 2017 21:50:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=traceback, H*r:sendmail X-HELO: mx0a-001b2d01.pphosted.com From: "Tulio Magno Quites Machado Filho" To: Rajalakshmi Srinivasaraghavan , libc-alpha@sourceware.org Cc: Rajalakshmi Srinivasaraghavan Cc: Subject: Re: [PATCH] powerpc: Improve memcmp performance for POWER8 In-Reply-To: <1491463760-1004-1-git-send-email-raji@linux.vnet.ibm.com> References: <1491463760-1004-1-git-send-email-raji@linux.vnet.ibm.com> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.51.1 (x86_64-unknown-linux-gnu) Date: Wed, 17 May 2017 21:50:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable x-cbid: 17051721-1523-0000-0000-000002A0544D X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17051721-1524-0000-0000-00002A36CDD7 Message-Id: <87wp9f40gy.fsf@totoro.lan> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-17_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=2 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705170165 X-SW-Source: 2017-05/txt/msg00522.txt.bz2 Rajalakshmi Srinivasaraghavan writes: > diff --git a/sysdeps/powerpc/powerpc64/multiarch/memcmp-power8.S b/sysdeps/powerpc/powerpc64/multiarch/memcmp-power8.S > new file mode 100644 > index 0000000..a568be4 > --- /dev/null > +++ b/sysdeps/powerpc/powerpc64/multiarch/memcmp-power8.S > @@ -0,0 +1,42 @@ > +/* Optimized memcmp implementation for PowerPC64/POWER8. > + Copyright (C) 2017 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#undef EALIGN > +#define EALIGN(name, alignt, words) \ > + .section ".text"; \ > + ENTRY_2(__memcmp_power8) \ > + .align ALIGNARG(alignt); \ > + EALIGN_W_##words; \ > + BODY_LABEL(__memcmp_power8): \ > + cfi_startproc; \ > + LOCALENTRY(__memcmp_power8) > + > +#undef END > +#define END(name) \ > + cfi_endproc; \ > + TRACEBACK(__memcmp_power8) \ > + END_2(__memcmp_power8) > + > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(name) > +#undef weak_alias > +#define weak_alias(name,alias) > + > +#include The patch LGTM in overall, except for this file. I think it should be implemented as in commit b6a66222096c. LGTM with that change. -- Tulio Magno