From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57157 invoked by alias); 22 Dec 2016 22:40:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 56828 invoked by uid 89); 22 Dec 2016 22:40:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mail.esperi.org.uk From: Nix To: Florian Weimer Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 03/15] Do not stack-protect ifunc resolvers. References: <20161219111528.14969-1-nix@esperi.org.uk> <20161219111528.14969-4-nix@esperi.org.uk> Date: Thu, 22 Dec 2016 22:40:00 -0000 In-Reply-To: (Florian Weimer's message of "Wed, 21 Dec 2016 15:17:30 +0100") Message-ID: <87wperoaeu.fsf@esperi.org.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DCC--Metrics: spindle 1481; Body=2 Fuz1=2 Fuz2=2 X-SW-Source: 2016-12/txt/msg00893.txt.bz2 On 21 Dec 2016, Florian Weimer outgrape: > On 12/19/2016 12:15 PM, Nix wrote: >> diff --git a/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c b/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c >> index 16c00d7..46608ee 100644 >> --- a/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c >> +++ b/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c >> @@ -33,6 +33,7 @@ >> # undef __gettimeofday >> >> int >> +inhibit_stack_protector >> __gettimeofday_vsyscall (struct timeval *tv, struct timezone *tz) >> { >> return INLINE_VSYSCALL (gettimeofday, 2, tv, tz); >> diff --git a/sysdeps/unix/sysv/linux/x86/gettimeofday.c b/sysdeps/unix/sysv/linux/x86/gettimeofday.c >> index c82452f..a419c4d 100644 >> --- a/sysdeps/unix/sysv/linux/x86/gettimeofday.c >> +++ b/sysdeps/unix/sysv/linux/x86/gettimeofday.c >> @@ -24,6 +24,7 @@ >> # include >> >> static int >> +inhibit_stack_protector >> __gettimeofday_syscall (struct timeval *tv, struct timezone *tz) >> { >> return INLINE_SYSCALL (gettimeofday, 2, tv, tz); > > These are functions *returned* by IFUNC resolvers, and therefore can > be compiled with stack protector enabled. I will drop those. I think I was a bit gettimeofday-trigger-happy when I wrote this. If it still works on x86-32 with -fstack-protector-all, you're clearly right :) -- NULL && (void)