From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78660 invoked by alias); 11 Mar 2016 21:12:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 78644 invoked by uid 89); 11 Mar 2016 21:12:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:755 X-HELO: e24smtp03.br.ibm.com X-IBM-Helo: d24dlp01.br.ibm.com X-IBM-MailFrom: tuliom@linux.vnet.ibm.com X-IBM-RcptTo: libc-alpha@sourceware.org From: "Tulio Magno Quites Machado Filho" To: Florian Weimer Cc: libc-alpha@sourceware.org, adhemerval.zanella@linaro.org, munroesj@linux.vnet.ibm.com Cc: Subject: Re: [PATCH v3] PowerPC: libc single-thread lock optimization References: <540080DF.6030205@linux.vnet.ibm.com> <1457721337-30897-1-git-send-email-tuliom@linux.vnet.ibm.com> <56E310BF.303@redhat.com> Date: Fri, 11 Mar 2016 21:12:00 -0000 In-Reply-To: <56E310BF.303@redhat.com> (Florian Weimer's message of "Fri, 11 Mar 2016 19:38:55 +0100") Message-ID: <87wpp867od.fsf@linux.vnet.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031121-0025-0000-0000-000006541A30 X-SW-Source: 2016-03/txt/msg00350.txt.bz2 Florian Weimer writes: > On 03/11/2016 07:35 PM, Tulio Magno Quites Machado Filho wrote: >> diff --git a/malloc/malloc.c b/malloc/malloc.c >> index b8a43bf..1eed794 100644 >> --- a/malloc/malloc.c >> +++ b/malloc/malloc.c >> @@ -4150,7 +4150,7 @@ static void malloc_consolidate(mstate av) >> maxfb = &fastbin (av, NFASTBINS - 1); >> fb = &fastbin (av, 0); >> do { >> - p = atomic_exchange_acq (fb, 0); >> + p = atomic_exchange_acq (fb, NULL); >> if (p != 0) { >> do { >> check_inuse_chunk(av, p); > > This should go in immediately and separately, it is independent of the > rest of the patch. Makes sense. I pushed this hunk as commit b43f552a. Thanks! -- Tulio Magno