From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Cc: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>,
Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH 1/2] setjmp: Use BSD sematic as default for setjmp
Date: Wed, 02 Aug 2023 16:43:23 +0200 [thread overview]
Message-ID: <87y1itqzck.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <ced6a96f-809e-2b99-9166-807bcd0ae780@linaro.org> (Adhemerval Zanella Netto's message of "Wed, 2 Aug 2023 10:29:14 -0300")
* Adhemerval Zanella Netto:
>> Ahh, you mean because use removed the signal unblocking from abort?
>>
>> If the signal is blocked, it is not delivered before it is unblocked.
>> This means that the handler will not observe it blocked.
>>
>> But POSIX says this:
>>
>> | The abort() function shall override blocking or ignoring the SIGABRT
>> | signal.
>>
>> It also says:
>>
>> | The SIGABRT signal shall be sent to the calling process as if by means
>> | of raise() with the argument SIGABRT.
>>
>> Strictly speaking, it is impossible to comply with both requirements,
>> but I think the handler is expected to run even if SIGABRT is blocked.
>> As far as I understand it, the new code terminates the process in this
>> case, without ever running the handler.
>
> The later has been changed with a new clarification [1]:
>
> The SIGABRT signal shall be sent to the calling [CX]thread[/CX] as if by
> means of raise() with the argument SIGABRT. [CX]If this signal does not
> terminate the process (for example, if the signal is caught and the handler
> returns), abort() may change the disposition of SIGABRT to SIG_DFL and send
> the signal (in the same way) again. If a second signal is sent and it does
> not terminate the process, the behavior is unspecified, except that the
> abort() call shall not return.[/CX]
>
> [1] https://austingroupbugs.net/view.php?id=906#c5851
Okay, I missed that change. So removing the unblocking should be okay
after this specification change. I still don't see how the removal of
unblocking changes the signal mask observed by the signal handler,
though.
Thanks,
Florian
next prev parent reply other threads:[~2023-08-02 14:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 17:18 [PATCH 0/2] Make abort AS-safe Adhemerval Zanella
2023-07-31 17:18 ` [PATCH 1/2] setjmp: Use BSD sematic as default for setjmp Adhemerval Zanella
2023-08-01 8:35 ` Florian Weimer
2023-08-01 13:51 ` Adhemerval Zanella Netto
2023-08-02 7:59 ` Florian Weimer
2023-08-02 12:32 ` Adhemerval Zanella Netto
2023-08-02 12:42 ` Florian Weimer
2023-08-02 12:48 ` Adhemerval Zanella Netto
2023-08-02 13:17 ` Florian Weimer
2023-08-02 13:29 ` Adhemerval Zanella Netto
2023-08-02 14:43 ` Florian Weimer [this message]
2023-08-02 14:56 ` Adhemerval Zanella Netto
2023-07-31 17:19 ` [PATCH 2/2] stdlib: Make abort AS-safe (BZ 26275) Adhemerval Zanella
2023-08-01 8:10 ` Florian Weimer
2023-08-01 13:52 ` Adhemerval Zanella Netto
2023-08-01 8:26 ` Florian Weimer
2023-08-01 13:57 ` Adhemerval Zanella Netto
2023-08-01 13:44 ` Cristian Rodríguez
2023-08-02 7:57 ` Florian Weimer
2023-08-02 13:08 ` Adhemerval Zanella Netto
2023-08-02 14:44 ` Florian Weimer
2023-08-02 14:48 ` Adhemerval Zanella Netto
2023-08-02 12:38 ` Florian Weimer
2023-08-02 13:08 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1itqzck.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).