From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id AA4BE3858D32 for ; Mon, 13 Mar 2023 10:08:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA4BE3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32D0KQ2A006618; Mon, 13 Mar 2023 10:08:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=Aap1Kc6oPwuK1yJgrjwWe/8QBFHSsGbuGZ7UFwdKzYc=; b=BWvlzUojpnI8yM6fdV4EHqmkm+/lDw/Tr7FpYKc56bIi09lUBjrixUgPuYoSc81z7Fll XLNiIPxORzRpe3nL0oRArzftlwsEcjZG97nyd4AQuc0cpehlzDIuppIeWVQvnrX2xLOu BOYqIOhUDDrnvlpbMAYbT3G0Rozcj8DQTfS8iIKIhwqjNzCOh2vQQl2XW0V/nWO4Y2k+ VALvpcoNFaRPRzmyQCHYOwF1XJYFdLSSP+dCoURxXZwhklz7ksDqra2L0nH0PGGsz6VA ToClJQnZ26JGbPVoBmzA9rq6274Zo8uZZ04z81JNtysvOTFkFknYZ2PWi9g0CjPTd0F6 zA== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p8hpcudva-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Mar 2023 10:08:49 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32D9O3Qa015266; Mon, 13 Mar 2023 10:08:49 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2169.outbound.protection.outlook.com [104.47.59.169]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3p8g34xb1h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Mar 2023 10:08:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B6BM71UPBfpG+tCNC3oSytEQ6pNG81akzvsuUe7ZT3AqSkK6S4tduiCF5WkyzsJExUIdnCPFhw3nhstOGYviwLSvL11mB3H+hM6C0fogPPqC380lSbGjlyoYqQSNgDk85O6J2cHOZK5CTJv1MpkIEHWnF2WtX0zVGDTJKVEHyHbNWd8+wkSx0+grtykbC/MeeB+d+vSlUNaV1hwx/jD7E22Oinn72/80OXqJ477hJIbF2bf5v905XCdSCSrm/9k3DgCvPGnDIR0p6iwniO037ibGdSAp00RCzalQG6CMKE6lpfDf7yedXfrW1ca4Yo4GdZKVDV0nsETp7ZMvwCvwbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aap1Kc6oPwuK1yJgrjwWe/8QBFHSsGbuGZ7UFwdKzYc=; b=br0XKNJhtbYPFKbZXN30y4ugLqHgxEMsHeQZC/mI4ogs76EyDj2t+MgX6KwXT1IOv6g3wOs83UjIQRChrVnAYdfKy886ZtRKi1fHZlF/LJNnffV1ZJz9o5p7R1p+khBMKg01yTr/Eg7hp7QBcgI8pPFoaJ1xLd28+4asqAg6sQMWH6Ae0kBhqw9An1GBCgJO7m9iyKVlVUNHu8LMBvihxGr0/G7zzQDvgydfEBqq9IKLCOC9P2PP56fEKGOJvgTNbW9qzQjw/eJVX8JvgZxwyxTC1X3Ju5L/P/mOWyNa1N/FsPTJs+LwYd9sCOuSNvxrWACrxryTL7RuIhezXoy2aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aap1Kc6oPwuK1yJgrjwWe/8QBFHSsGbuGZ7UFwdKzYc=; b=kmbNtNn/iMO6QuWsu6jBR1rtI+wxxfrWW8xoIuL98NLEImINSG4f2aap4pPCWlTxO7NJIw2ZPUgsbOtkrHZapNuXGCYK7Eh3XKa/+rTM7D0+/0M7TcbaGW+vhAdl3UP0zIy7enida+8P88P4ePqS7JO8MlsaGyUuptADfESCIVM= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by PH7PR10MB5770.namprd10.prod.outlook.com (2603:10b6:510:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 10:07:58 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6178.022; Mon, 13 Mar 2023 10:07:58 +0000 References: <20230310143558.361825-1-cupertino.miranda@oracle.com> <20230310143558.361825-2-cupertino.miranda@oracle.com> <87edptulvd.fsf@oldenburg.str.redhat.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Florian Weimer Cc: Cupertino Miranda via Libc-alpha , jose.marchesi@oracle.com, elena.zannoni@oracle.com, adhemerval.zanella@linaro.org Subject: Re: [PATCH] Created tunable to force small pages on stack allocation. In-reply-to: <87edptulvd.fsf@oldenburg.str.redhat.com> Date: Mon, 13 Mar 2023 10:07:52 +0000 Message-ID: <87y1o10xs7.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0652.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::13) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|PH7PR10MB5770:EE_ X-MS-Office365-Filtering-Correlation-Id: 82a2787f-9309-4eaf-9eda-08db23aad267 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q3uhbYsQh4InM9cI2GjXaATle4WWDw1jYh1anaoaIG0ZJkn7bBd/jpFfhbvt/itMwhCiqRFGmUaiiXSvHgaMYmrF2qzM/+1oqggCY1RyKiGwwLiFNTsODXr/FdA/2jsDlluQ4/C+eLzx+5NgGD/V+2cC4K3MrW9o1TP1CHz8HESbGw9rIjNltHJnWgNPyPN6GphtJC4CBsfeUKaILSbbPDtL5p3N8FeFNYIawkStmWG+N46WwFtYcSEhtrIjKawx7jdPNjn9c+o+c4QJgR0J4dO5VbJo5Hh4vTRRiPpRp68O13pVefUToa00vTPCrgRSfiGCgKuqL3YRr6VfO292f6WgzaOlq2UC8AGuA0j2sywXGNV8I1LEqxvk3a+czXv2PYK2cmj7XQwOChqLhn4M+IbZsl9UxvHcjoYriRNSRMlJ7Vq0//I6o76XmFSFJSs7yUmhFeXuwGhT4uANKDeTGGwZlzfasQeGKw+zN9bshxs8V5+10UyWHR7QiLTxayRQ33HQ6UnxWGHHiiVJzL/euiNsVWM3w447Bfz4UOll9h4aWCYCbHrURpSSwKfi+6FYMG4y6cC/G4c+JVuIyBd9JaTAxLHDdztEyULlLt6/H01LhnyoXB3TxCbh7hoN2W8PS38GnZ07YLooauskYwEW+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(346002)(376002)(396003)(366004)(451199018)(6512007)(6506007)(26005)(2616005)(6666004)(186003)(44832011)(2906002)(6486002)(5660300002)(316002)(41300700001)(66556008)(66946007)(66476007)(38100700002)(36756003)(6916009)(4326008)(8676002)(478600001)(8936002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v/VqH1ujX2Wt3DyzAkDiszj93eMw1D4VaoTsUZs9VsXR2iDHRN4iNSQ7lhYf?= =?us-ascii?Q?9b1FBL7s/GUQXYmrwvmLwiilEUqSUzm9L2dci1ZpIGurA3QgHSVJ96nY6d7O?= =?us-ascii?Q?mbS8D3fT475GGpBBTr2BD9U0ZS3OCSgskRbvJsLqGYzDjYQek1Oy094shJub?= =?us-ascii?Q?HERij9W0TUjBPUkliKuAdu0w5n2TSXuCo6NGuEM4oNr7VJuAWbFKQMif/ZDC?= =?us-ascii?Q?VBxP1jvRq3uMUuVzkVUytHdavCa+ATC8f8i25/T9S+4UWbTke5UXii0qQGh0?= =?us-ascii?Q?HIHDJ2pO0Frr/NccziVwHIQpeXcMuRwgAnGYH3+5YZDZdfvDi0ykhLU2Zt5x?= =?us-ascii?Q?uFmGlOyyHfraBkNREatEkXlKawxUfnYtzMYMBlH6cFqkYMgm1ntgPYCz8bq9?= =?us-ascii?Q?w8bt+iAY8e8Bhc6w3T00POmHSxluCTJnL9XUh6zG3ciKYkkDjQXoMl1Ko44J?= =?us-ascii?Q?eRFs9CwDnaludAwNYOkDUwffj4iDN3atn530a8LpU1MwPJzqLKHy/wmnIGhA?= =?us-ascii?Q?jreM3dDe0X0UwDsuKpPO2FUabqFTie5kR5bR5jUSKt8dFYlENQOTMXFpWUF+?= =?us-ascii?Q?g0EuGjd7MfHv8o97DaCtifef4pG89I0gv39nMZWEdtGVf9JH9b65Y+BOHwOl?= =?us-ascii?Q?PLMhlRYXoL1IfuzfaTizXGye3EtAuCGDrC77Z5t+pbOD3TC2EsOBGw5bAvMn?= =?us-ascii?Q?Orl/jTsol/3G0uFLp23qXOHSXOyb4uoy99ewGzVAAU/XTNqa/wqOu+bge/jt?= =?us-ascii?Q?sE1D11F3gmJCQRF+ASVNMbVQEcd3H+oePeRLT5dWUorZPq/rHTc+r4kIRff2?= =?us-ascii?Q?peBTpb2UuybN0Cr77vvsfHy4mzS41J77LG9TezJwAfsZ4H3c6rQMTs/CyKAp?= =?us-ascii?Q?x6Cfs/1Bf/WcsBiNnihOq11oHtUXvEE52PS9G9W+i2w79Cu5PzTWhfmcH6qX?= =?us-ascii?Q?v3wBLXmYBAY3m+biEj1oYMVMehxk4G81ZxX1aSLa4nXcSo44EINeyE5wnbbS?= =?us-ascii?Q?VcvZBbwWxSx0glIn4QLnD4WuVgbval0bIKJRclcO702N4oIT0LfiFXMk8Wj0?= =?us-ascii?Q?D4zLIc3zCtZbmIOk+LH+3RSQlgow6iKby/kA4KOGSGI/rN2Mntm5ji5SGcp/?= =?us-ascii?Q?CSssPMe3lY/1rT12bvpEV6NFDrEyQYJXzBkmAx+A6/+s/PwXdsASyQkBO3hm?= =?us-ascii?Q?oRrRB0Lx98uSemhmxBpRRusaLHrY6qU02o8fzjwmsRw1kE4mlQtyT9JJPI4f?= =?us-ascii?Q?G9wU/aVROLU2dv5KTzpoP/0735skUmByYQRIkLUloplWRhBurd7uWZrCScrF?= =?us-ascii?Q?I2AKuz3JC7tjBMMgmQjNQnOxNDJ6Mfyq5cX1AjsvsLeProRgJLDmgUc+ye/h?= =?us-ascii?Q?zVLLdEH3aq1OI5t77GnBDYCljm1f12ZHhM64XlMSCYAm3g+HFmOIgFC6i4it?= =?us-ascii?Q?1cBSqO3rLWEf7HXpGRZ5sEO3nJcAdiicrxnUAcDoMiYxhhbSeq7lIeRRigsf?= =?us-ascii?Q?yocG6IwpU/5sw6YDoHq1AdpwC49qgv0Yu6s+Ii7xe3qmbfxBezWJqf9opU+o?= =?us-ascii?Q?DvDFTFlBZ62ZqSsZHGPzdS2WqlTj5xuqo2Lb9kM0vxUB9ZDYoPYKsgcWZ0f9?= =?us-ascii?Q?JQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qzPyuQACduogJ4l7No6nciZ9i3ICK6gB183XoFxBM7V6RNljefuydqwpQ8JgkfxnOgutYsdG3SPzRrslsfmLhBWbi8gveCrz8cyHd8yEEq9tpqDnni3M+tFD9J+PVnAX+vL7O7oO2rHGxVbTIRPUoHdGgJOQIbSX08xaaiU9fjibkOLCt3gZtC7TDe/4Ig4zIVYM7XeVVRzWMlUIZiYb740v+8tOVFhDbId0Xby1MMB7AeE8mdK1awyHqQutPv2ae+Ph7If1eHoRsrom5CcnkciC3slKnD1LrLGBV8V/gw2iZI+LuyZ9lr+6pAZAqoK3m5Su27VGt/w74eYL8v9etGlbuN/dG0hd1REH2RNusvWEjm4nYUK/epdYdeXgWeyrsISrieCc8Dg/jtYDUFeYx9kQz4K4/KbR4IH7stBDP7njFvUZq6armNSK23TGg5EyJraIvQs0VJwHv52udYawtzRIxMRAJRUPgZP2FV3cKSHTqcFtnPsCpTo56Yb3jdkZZKUvfDBcel1hnhPqQZ2Nwiw0cpSXVXRlzZQ9nzKPIIkIXEpVUJlMBURcarhkRExpvVnhcSwYElxU97jdIf0+jep0jSf+8Mdv+QDyUsMWitpMegTDkec+4kW+E579EuNYzXETHazKkIe9ofXqqDkjFvMnQZpETiEE1sTR/b+uecLlYbLkdT+ad70IhQRDIE7RphqZtTo1hsqy40wdYzIKSiKeQpj86fkDS7au/MZR7lu0ABfgqDuViScFMM1zwH6l1g/EeN1kgLjzUa251X7VtZYFOnD6ZFMbkZv5T2+tu/G6E/iieN5Eiaa8yp5FEuqi X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82a2787f-9309-4eaf-9eda-08db23aad267 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 10:07:58.6350 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S/8s3hpYCwBw3mtX34vtui5WO/6aKAndATDEZRIo8PtVj28pqpKOogle1v21ei8HxhGFugRhRRbxsHVk0PZ2IcmZ/Bk/FiDDI8sW4NhaO7w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5770 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-13_03,2023-03-10_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303130083 X-Proofpoint-ORIG-GUID: 8FkfWqvBz7Bvjb8zNBzOijtk3zNaF-MH X-Proofpoint-GUID: 8FkfWqvBz7Bvjb8zNBzOijtk3zNaF-MH X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Florian > * Cupertino Miranda via Libc-alpha: > >> +static void >> +TUNABLE_CALLBACK (set_stack_hugetlb) (tunable_val_t *valp) >> +{ >> + enum malloc_thp_mode_t thp_mode = __malloc_thp_mode (); >> + /* >> + Only allow to change the default of this tunable if the system >> + does support and has either 'madvise' or 'always' mode. Otherwise >> + the madvise() call is wasteful. >> + */ >> + switch(thp_mode) >> + { >> + case malloc_thp_mode_always: >> + case malloc_thp_mode_madvise: >> + __nptl_stack_hugetlb = (int32_t) valp->numval; >> + break; >> + default: >> + break; >> + } >> +} > > I suspect that quite a few failing madvise calls are cheaper than the > those three system calls in __malloc_thp_mode. In addition, > __malloc_thp_mode may fail due to future kernel changes, disabling the > tunable by accident. Thanks for your review. Ok, I did not check the inner workings of malloc_thp_mode. I used it by suggestion from the RFC thread. I will prepare a version removing it. > > Thanks, > Florian