From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id EE34D3857379 for ; Thu, 14 Apr 2022 15:27:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EE34D3857379 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4KfNcf35Pjz1s75T; Thu, 14 Apr 2022 17:27:30 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4KfNcf2vn9z1qqkC; Thu, 14 Apr 2022 17:27:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id DHfnMhsta1LN; Thu, 14 Apr 2022 17:27:29 +0200 (CEST) X-Auth-Info: 8c6VQl84I6YyeAIsMUambrjwPidl1y6n7RTuNERrPUYgGB1oyTwoC+8AC4z6cmA2 Received: from igel.home (ppp-46-244-164-67.dynamic.mnet-online.de [46.244.164.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 14 Apr 2022 17:27:29 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id EB54A2C39A8; Thu, 14 Apr 2022 17:27:28 +0200 (CEST) From: Andreas Schwab To: Florian Weimer via Libc-alpha Cc: Florian Weimer Subject: Re: [PATCH] manual: Document the dlinfo function References: <87zgknwvvh.fsf@oldenburg.str.redhat.com> X-Yow: Here I am at the flea market but nobody is buying my urine sample bottles.. Date: Thu, 14 Apr 2022 17:27:28 +0200 In-Reply-To: <87zgknwvvh.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Thu, 14 Apr 2022 17:02:58 +0200") Message-ID: <87y207y9b3.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 15:27:33 -0000 On Apr 14 2022, Florian Weimer via Libc-alpha wrote: > +@item RTLD_DI_SERINFO > +@item RTLD_DI_SERINFOSIZE The second @item needs to be @itemx. > +These requests can be used to obtain search path information for > +@var{handle}. For both requests, @var{arg} must point to a > +@code{Dl_serinfo} object. The @code{RTLD_DI_SERINFOSIZE} request must > +be made first; it updates the @code{@var{arg}->dls_size} and > +@code{@var{arg}->dls_cnt} members. This is misleading since arg is a void pointer. Perhaps just refer to the members by their name: ... it updates the @code{dls_size} and @code{dls_cnt} members of the @code{Dl_serinfo} object. > +This interface is prone to buffer overflows in multi-threaded because +processes > +@item RTLD_DI_TLS_DATA > +This request writes the address of the TLS block (in the current thread) > +for the shared object identified by @var{handle} to a @code{void *} > +object at address @var{arg} (that is, @var{arg} must be of type > +@code{void **}). This description is weirdly different from the others wrt. how @var{arg} is described. I think how the other places describe it is better. > +The reminder of this section documents the @code{_dl_find_object} remainder -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."