From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E52E33858D28 for ; Fri, 17 Dec 2021 17:44:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E52E33858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638-9ypaqbMRNRu8BUYL9YCl7w-1; Fri, 17 Dec 2021 12:43:59 -0500 X-MC-Unique: 9ypaqbMRNRu8BUYL9YCl7w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6B4891800D50; Fri, 17 Dec 2021 17:43:58 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.46]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AD18196E2; Fri, 17 Dec 2021 17:43:52 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v6 09/20] elf: Add _dl_audit_pltexit References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-10-adhemerval.zanella@linaro.org> Date: Fri, 17 Dec 2021 18:43:50 +0100 In-Reply-To: <20211115183734.531155-10-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Mon, 15 Nov 2021 15:37:23 -0300") Message-ID: <87y24jgm95.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 17:44:01 -0000 * Adhemerval Zanella: > +#if (!ELF_MACHINE_NO_RELA && !defined ELF_MACHINE_PLT_REL) \ > + || ELF_MACHINE_NO_REL > +# define PLTREL ElfW(Rela) > +#else > +# define PLTREL ElfW(Rel) > +#endif Can you move this definition into some shared header, so that elf/dl-runtime.c and elf/dl-audit.c can use a single definition? I have looked at the actual _dl_audit_pltexit function introduction, and it looks okay. But I'd review this again as part of a repost, actually applying the patch. Thanks, Florian