From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id B965A3858002 for ; Wed, 17 Nov 2021 15:40:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B965A3858002 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4HvRvY2nrPz1sCTt; Wed, 17 Nov 2021 16:40:09 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4HvRvY2MJ2z1qqkD; Wed, 17 Nov 2021 16:40:09 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id l3UuT59O_bap; Wed, 17 Nov 2021 16:40:08 +0100 (CET) X-Auth-Info: vn+04meDDKmGC6N+0QgpedR2SggwuDLMCJtc5CAM0XjYnMWCJJZIRAUcHToSXi4H Received: from igel.home (ppp-46-244-173-211.dynamic.mnet-online.de [46.244.173.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 17 Nov 2021 16:40:08 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 398752C3AE3; Wed, 17 Nov 2021 16:40:08 +0100 (CET) From: Andreas Schwab To: Florian Weimer via Libc-alpha Cc: Florian Weimer Subject: Re: [PATCH] socket: Do not use AF_NETLINK in __opensock References: <87ilwq6bu1.fsf@oldenburg.str.redhat.com> X-Yow: A can of ASPARAGUS, 73 pigeons, some LIVE ammo, and a FROZEN DAQUIRI!! Date: Wed, 17 Nov 2021 16:40:08 +0100 In-Reply-To: <87ilwq6bu1.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 17 Nov 2021 16:28:22 +0100") Message-ID: <87y25mzt7r.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Nov 2021 15:40:12 -0000 On Nov 17 2021, Florian Weimer via Libc-alpha wrote: > diff --git a/socket/opensock.c b/socket/opensock.c > index ff94d27a61..cf4731abf1 100644 > --- a/socket/opensock.c > +++ b/socket/opensock.c > @@ -29,12 +29,6 @@ __opensock (void) > int type = SOCK_DGRAM | SOCK_CLOEXEC; > int fd; > > -#ifdef AF_NETLINK > - fd = __socket (AF_NETLINK, type, 0); > - if (fd >= 0) > - return fd; > -#endif The comment is now outdated. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."