From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7166D3838037 for ; Tue, 15 Jun 2021 19:19:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7166D3838037 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-WiKnA2_gP9mYQPngEN2dIQ-1; Tue, 15 Jun 2021 15:19:08 -0400 X-MC-Unique: WiKnA2_gP9mYQPngEN2dIQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D41D98186E1 for ; Tue, 15 Jun 2021 19:19:07 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-60.ams2.redhat.com [10.36.115.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8FBC60861; Tue, 15 Jun 2021 19:19:02 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org, Jakub Jelinek Subject: Re: [PATCH] nptl: Export _pthread_cleanup_push, _pthread_cleanup_pop again References: <87r1h3gnlx.fsf@oldenburg.str.redhat.com> Date: Tue, 15 Jun 2021 21:19:00 +0200 In-Reply-To: (Carlos O'Donell's message of "Tue, 15 Jun 2021 15:17:03 -0400") Message-ID: <87y2bbey1n.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2021 19:19:11 -0000 * Carlos O'Donell: > On 6/15/21 11:21 AM, Florian Weimer via Libc-alpha wrote: >> These were turned into compat symbols as part of the libpthread >> move. It turns out they are used by language run-time libraries >> (e.g., the GCC D front end), so it makes to preserve them as >> external symbols even though they are not declared in any header >> file. >> >> Tested on i686-linux-gnu, x86_64-linux-gnu. Built on i686-gnu. (No >> full build on all ABIs, but the ABI update was done with >> update-all-abi.) > > Just like the pthread min stack size problem this is something we can't > change until we work with the runtime authors to avoid the regression or > get interfaces they need defined. > > Thanks for working through this issue. This change is straight forward, > we aren't at ABI freeze yet, and so this looks good to me. Just to be clear, this is a public interface, not a GLIBC_PRIVATE one. It's just an old interface that unexpectedly has current users. > Reviewed-by: Carlos O'Donell Thanks! Florian