From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A821A388A432 for ; Wed, 2 Jun 2021 18:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A821A388A432 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-242-5bVEaascPyqKtANHdo7wOQ-1; Wed, 02 Jun 2021 14:30:44 -0400 X-MC-Unique: 5bVEaascPyqKtANHdo7wOQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2089501E3; Wed, 2 Jun 2021 18:30:42 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B60E85D9C6; Wed, 2 Jun 2021 18:30:41 +0000 (UTC) From: Florian Weimer To: Joseph Myers Cc: Andreas Schwab , Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v3] nptl: Deallocate the thread stack on setup failure (BZ #19511) References: <20210527172823.3461314-3-adhemerval.zanella@linaro.org> <20210602125644.3725112-1-adhemerval.zanella@linaro.org> <87r1hkjtwj.fsf@igel.home> <4e623fa1-419e-5c54-2da3-61a2c3f143ed@linaro.org> <87mts8jsda.fsf@igel.home> <28311d99-55b0-808f-5130-1a9895b9cf77@linaro.org> <87im2wjr6f.fsf@igel.home> Date: Wed, 02 Jun 2021 20:30:39 +0200 In-Reply-To: (Joseph Myers's message of "Wed, 2 Jun 2021 18:20:14 +0000") Message-ID: <87y2bst8z4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 18:30:49 -0000 * Joseph Myers: > On Wed, 2 Jun 2021, Andreas Schwab wrote: > >> On Jun 02 2021, Adhemerval Zanella wrote: >> >> > I don't have a strong preference here, maybe use a 'bool' then? >> >> bool has architecture dependent size. > > bool is one byte for all configurations supported by glibc (the only > configuration supported by GCC for which it isn't is powerpc-darwin). > Although I don't see any likely reason for glibc code to depend on it > being one byte. However, one reason not to use bool in internal code is that our own atomics do not support one-byte types on all architectures. For example this definition in sysdeps/powerpc/atomic-machine.h: #define atomic_exchange_acq(mem, value) \ ({ \ __typeof (*(mem)) __result; \ if (sizeof (*mem) == 4) \ __result = __arch_atomic_exchange_32_acq (mem, value); \ else if (sizeof (*mem) == 8) \ __result = __arch_atomic_exchange_64_acq (mem, value); \ else \ abort (); \ __result; \ }) Thanks, Florian